Skip to content

feat: update deps#45

Merged
nathanosdev merged 1 commit intomainfrom
nathan/update-deps
Mar 18, 2025
Merged

feat: update deps#45
nathanosdev merged 1 commit intomainfrom
nathan/update-deps

Conversation

@nathanosdev
Copy link
Copy Markdown
Contributor

No description provided.

@nathanosdev nathanosdev requested a review from a team as a code owner March 18, 2025 10:44
@nathanosdev nathanosdev self-assigned this Mar 18, 2025
@nathanosdev nathanosdev requested a review from Copilot March 18, 2025 10:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates several dependency versions and adjusts dependency management for the workspace while also modifying error handling patterns in the HTTP gateway protocol handler.

  • Updated dependency versions in Cargo.toml (ic-cdk, ic-agent, etc.) and adjusted version constraints for certification packages.
  • Transitioned local dependencies in packages/ic-http-gateway/Cargo.toml to be managed via the workspace.
  • Updated pattern matching in packages/ic-http-gateway/src/protocol/handler.rs for AgentError variants to align with the new error type structure.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Cargo.toml Bumped and constrained dependency versions, added reqwest, and adjusted versions for ic-* packages.
packages/ic-http-gateway/Cargo.toml Converted specific version requirements for reqwest and testcontainers to workspace-managed dependencies.
packages/ic-http-gateway/src/protocol/handler.rs Updated error handling match patterns to destructure the 'reject' field explicitly.
Comments suppressed due to low confidence (2)

Cargo.toml:51

  • Please confirm that changing 'assert_matches' from "1.5" to "1" is intentional and does not introduce any compatibility issues in tests.
assert_matches = "1"

packages/ic-http-gateway/Cargo.toml:40

  • Verify that switching from a fixed version ('0.12.8') to a workspace-managed 'reqwest' dependency ensures the expected version is used across all workspace members.
reqwest.workspace = true

Copy link
Copy Markdown
Contributor

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nathanosdev nathanosdev merged commit 478fadc into main Mar 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants