Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates several dependency versions and adjusts dependency management for the workspace while also modifying error handling patterns in the HTTP gateway protocol handler.
- Updated dependency versions in Cargo.toml (ic-cdk, ic-agent, etc.) and adjusted version constraints for certification packages.
- Transitioned local dependencies in packages/ic-http-gateway/Cargo.toml to be managed via the workspace.
- Updated pattern matching in packages/ic-http-gateway/src/protocol/handler.rs for AgentError variants to align with the new error type structure.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Bumped and constrained dependency versions, added reqwest, and adjusted versions for ic-* packages. |
| packages/ic-http-gateway/Cargo.toml | Converted specific version requirements for reqwest and testcontainers to workspace-managed dependencies. |
| packages/ic-http-gateway/src/protocol/handler.rs | Updated error handling match patterns to destructure the 'reject' field explicitly. |
Comments suppressed due to low confidence (2)
Cargo.toml:51
- Please confirm that changing 'assert_matches' from "1.5" to "1" is intentional and does not introduce any compatibility issues in tests.
assert_matches = "1"
packages/ic-http-gateway/Cargo.toml:40
- Verify that switching from a fixed version ('0.12.8') to a workspace-managed 'reqwest' dependency ensures the expected version is used across all workspace members.
reqwest.workspace = true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.