feat: [DSM-103] Actual priority queue for long executions#10013
Merged
alin-at-dfinity merged 2 commits intomasterfrom Apr 27, 2026
Merged
feat: [DSM-103] Actual priority queue for long executions#10013alin-at-dfinity merged 2 commits intomasterfrom
alin-at-dfinity merged 2 commits intomasterfrom
Conversation
Instead of a binary prioritized / opportunistic flag, explicitly (record and) prioritize long executions based on number of slices executed, AP and round when the long execution started. This ensures that we don't starve low priority canisters (which may happen with bounded AP and just the right distribution across execution cores). Also switch from persisting SubnetSchedule spread across individual canister states to persisting it as part of the subnet's SystemMetadata.
alin-at-dfinity
commented
Apr 24, 2026
adambratschikaye
approved these changes
Apr 27, 2026
Co-authored-by: Adam Bratschi-Kaye <adam.bratschikaye@dfinity.org>
basvandijk
added a commit
that referenced
this pull request
Apr 27, 2026
#10013)" (#10030) This reverts commit 9882446 because it breaks the `//rs/tests/consensus:subnet_splitting_test_colocate` test: ``` 2026-04-27 12:20:33.510 INFO[uvms_logs_stream:StdOut] [uvm=colocated-test-driver] TEST_LOG: 2026-04-27 12:20:33.310 INFO[subnet_splitting_test:StdErr] thread 'main' (126) panicked at rs/tests/consensus/subnet_splitting_test.rs:173:33: 2026-04-27 12:20:33.510 INFO[uvms_logs_stream:StdOut] [uvm=colocated-test-driver] TEST_LOG: 2026-04-27 12:20:33.310 INFO[subnet_splitting_test:StdErr] Execution of step SplitOutDestinationState failed: Validation failed: State hash after split b55a0fa013f5d9aa08c1cfc70d683e7b1dbdda7d0789d47ff705b044c45000d1 doesn't match the expected state hash 0295d8206a0b9b88b95291d1d8d31beb4a837794036882b097e38c740a917892 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a binary prioritized / opportunistic flag, explicitly (record and) prioritize long executions based on number of slices executed, AP and round when the long execution started. This ensures that we don't starve low priority canisters (which may happen with bounded AP and just the right distribution across execution cores).
Also switch from persisting
SubnetSchedulespread across individual canister states to persisting it as part of the subnet'sSystemMetadata.