chore: CON-1453 Introduce a type for remote transcript results#10250
Merged
Conversation
pierugo-dfinity
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of the verbose
(NiDkgId, CallbackId, Result<NiDkgTranscript, String>)triple, this PR introduces a dedicated struct for remote NiDKG transcript creation results.Additionally, we remove all mentions of "early" remote transcripts. After #10055, "early" transcript creation (i.e. as part of data blocks) is the only way for remote transcripts to be created, since they can no longer be part of summary blocks. Therefore, we can drop the "early" prefix.
Note that, although we change the type of the summary payload, this change is backward/forward compatible (see passing
cup_compatibility_test). This is because the hash function of the triple is equal to the one of the struct, therefore no migration is necessary.