test(sns): Migrate upgrade qualification tests to AdvanceSnsTargetVersion#2981
Merged
test(sns): Migrate upgrade qualification tests to AdvanceSnsTargetVersion#2981
Conversation
anchpop
force-pushed
the
@anchpop/new-qualification-tests
branch
3 times, most recently
from
cc3a379 to
1f2bca4
Compare
anchpop
changed the title
Contributor
|
Didn't we agree to keep the old tests in addition to adding the new ones? I don't see any new bazel targets. |
anchpop
changed the title
aterga
reviewed
Dec 10, 2024
rs/nervous_system/integration_tests/tests/sns_upgrade_test_utils.rs
Outdated
Show resolved
Hide resolved
aterga
reviewed
Dec 10, 2024
rs/nervous_system/integration_tests/tests/sns_upgrade_test_utils.rs
Outdated
Show resolved
Hide resolved
aterga
reviewed
Dec 10, 2024
rs/nervous_system/integration_tests/tests/sns_upgrade_test_utils.rs
Outdated
Show resolved
Hide resolved
aterga
reviewed
Dec 10, 2024
rs/nervous_system/integration_tests/tests/sns_upgrade_test_utils.rs
Outdated
Show resolved
Hide resolved
aterga
approved these changes
Dec 10, 2024
anchpop
force-pushed
the
@anchpop/new-qualification-tests
branch
2 times, most recently
from
addbf52 to
72ac576
Compare
anchpop
force-pushed
the
@anchpop/new-qualification-tests
branch
from
72ac576 to
4fc280c
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
This was disabled until we updated SNS Gov on mainnet (as previously SNS Swap did not upgrade). Closes [NNS1-3433](https://dfinity.atlassian.net/browse/NNS1-3433) #2981 already did this for the legacy (UpgradeSnsToNextVersion) upgrade qualifications, this PR does it for AvanceSnsTargetVersion upgrade qualifications as well. [NNS1-3433]: https://dfinity.atlassian.net/browse/NNS1-3433?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Note: This PR also cleans up a comment in `sns_release_qualification_legacy.rs`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade tests are implemented by calling
test_sns_upgrade. This PR changes that function to use the new mechanism rather than the old. I don't think it's necessary to retain test coverage for the old mechanism.NNS1-3441