chore(consensus): [CON-1341] inline node_registration_test and ssh_access_to_nodes_test system tests#481
Merged
kpop-dfinity merged 32 commits intoJul 22, 2024
Conversation
…est_and_node_registration_test
basvandijk
reviewed
Jul 19, 2024
basvandijk
reviewed
Jul 19, 2024
basvandijk
approved these changes
Jul 19, 2024
Collaborator
basvandijk
left a comment
basvandijk
left a comment
There was a problem hiding this comment.
Awesome job inlining these tests. I'll use you as a shining example that other teams should follow!
…est_and_node_registration_test
kpop-dfinity
deleted the
kpop/CON-1341/inline_ssh_access_to_nodes_test_and_node_registration_test
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.