refactor(nns): Move governance::init to its own crate to further split type dependencies#490
Merged
Merged
Conversation
max-dfinity
force-pushed
the
detangle-governance-api-types
branch
2 times, most recently
from
19a47fe to
367a21d
Compare
max-dfinity
changed the title
max-dfinity
force-pushed
the
detangle-governance-api-types
branch
4 times, most recently
from
b3bd085 to
0397896
Compare
max-dfinity
force-pushed
the
detangle-governance-api-types
branch
3 times, most recently
from
da0a570 to
37b54ce
Compare
max-dfinity
force-pushed
the
detangle-governance-api-types
branch
from
58b984a to
608331b
Compare
max-dfinity
force-pushed
the
detangle-governance-api-types
branch
from
2189752 to
632bcd7
Compare
max-dfinity
changed the title
max-dfinity
force-pushed
the
detangle-governance-api-types
branch
2 times, most recently
from
3aabd3f to
35bde28
Compare
max-dfinity
force-pushed
the
detangle-governance-api-types
branch
2 times, most recently
from
cf4d362 to
e4db739
Compare
max-dfinity
force-pushed
the
detangle-governance-api-types
branch
from
e4db739 to
e46a5d2
Compare
max-dfinity
force-pushed
the
detangle-governance-api-types
branch
from
ae9acb7 to
230ca90
Compare
max-dfinity
commented
Jul 24, 2024
max-dfinity
commented
Jul 24, 2024
basvandijk
approved these changes
Jul 24, 2024
jasonz-dfinity
approved these changes
Jul 24, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls out a struct into its own crate that is a common reason for other crates to depend the ic_nns_governance crate. This further helps separate out the NNS Governance canister from other parts of the code