Skip to content

chore(XC): remove deprecation from ic-cdk in ic-btc-checker#6755

Merged
gregorydemay merged 7 commits into
masterfrom
gdemay/XC-455-remove-ic-cdk-deprecation
Sep 26, 2025
Merged

chore(XC): remove deprecation from ic-cdk in ic-btc-checker#6755
gregorydemay merged 7 commits into
masterfrom
gdemay/XC-455-remove-ic-cdk-deprecation

Conversation

@gregorydemay
Copy link
Copy Markdown
Contributor

@gregorydemay gregorydemay commented Sep 15, 2025

Follow-up to #6264 to remove the introduced #![allow(deprecated)] in the code of the ic-btc-checker canister:

  1. in rs/bitcoin/checker/src/main.rs
  2. in rs/bitcoin/checker/tests/tests.rs

@github-actions github-actions Bot added the chore label Sep 15, 2025
# Conflicts:
#	rs/bitcoin/checker/src/main.rs
#	rs/bitcoin/checker/src/providers.rs
#	rs/bitcoin/checker/src/state.rs
#	rs/bitcoin/checker/tests/tests.rs
@gregorydemay gregorydemay changed the title chore(XC): remove deprecation chore(XC): remove deprecation from ic-cdk in ic-btc-checker Sep 15, 2025
@gregorydemay gregorydemay marked this pull request as ready for review September 16, 2025 05:08
@gregorydemay gregorydemay requested a review from a team as a code owner September 16, 2025 05:08
Copy link
Copy Markdown
Contributor

@ninegua ninegua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@gregorydemay gregorydemay added this pull request to the merge queue Sep 26, 2025
Merged via the queue into master with commit 5504513 Sep 26, 2025
34 checks passed
@gregorydemay gregorydemay deleted the gdemay/XC-455-remove-ic-cdk-deprecation branch September 26, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants