test(ckdoge): regtest #8214
Merged
test(ckdoge): regtest #8214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # rs/dogecoin/ckdoge/minter/src/address/mod.rs # rs/dogecoin/ckdoge/minter/src/transaction/mod.rs # rs/dogecoin/ckdoge/minter/src/transaction/tests.rs # rs/dogecoin/ckdoge/minter/src/updates/get_doge_address.rs # rs/dogecoin/ckdoge/minter/src/updates/tests.rs # rs/dogecoin/ckdoge/test_utils/src/dogecoin.rs
gregorydemay
commented
Jan 12, 2026
mducroux
approved these changes
Jan 14, 2026
Contributor
mducroux
left a comment
mducroux
left a comment
There was a problem hiding this comment.
Thanks for this very useful PR @gregorydemay. Left only a few minor comments
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
…ns increases (#8345) Follow-up on #8214 to ensure the fee rate of a replacement transaction always increases. Although not a requirement of [BIP-125](https://github.com/bitcoin/bips/blob/master/bip-0125.mediawiki), this constraint is actually enforced by Dogecoin and Bitcoin miners and is part of the [implementation](bitcoin/bitcoin#6871) referenced in the BIP > Replaces transactions already in the mempool if a new transaction seen with a higher fee, specifically both **a higher fee per KB** and a higher absolute fee. This PR ensures this by 1. Recording the effective fee rate of a sent transaction instead of the initially estimated fee rate. The effective fee rate may be higher than the estimated one due the encoded signatures of the sent transaction requiring potentially less bytes than what was estimated (DER encoding of signatures is not constant size). This ensures that adding the relay fee for the replacement transaction does indeed increase the fee rate of the replacement transaction. 2. Rounding the estimated fee up to ensure that the effective fee rate is always at least the estimated one. --------- Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #8187: to ensure that Dogecoin transactions produced by the minter are indeed correct, change all the existing ckDOGE integration tests to use the true Dogecoin daemon in regtest mode instead of the simple mock used until now (that's still being used for the ckBTC integration tests). This has two main merits:
2.Ease testing and debugging scenarios in Regtest mode.