Skip to content

Conversation

@nmattia
Copy link
Contributor

@nmattia nmattia commented Jan 16, 2026

This reverts commit 56ba3cf.

The new build-ic.sh logic appears to be incorrect, and the caller is not automatically dropping into the container.

This reverts commit 56ba3cf.

The new `build-ic.sh` logic appears to be incorrect, and the caller is
not automatically dropping into the container.
…a65e0e6743376a164c7348c9aa475a

Image tag: 057e56cf5ed9e5dafad7526846b8f476c316d689ebccf1b5504dfc5bff885a30
@github-actions
Copy link
Contributor

Run URL: https://github.com/dfinity/ic/actions/runs/21074016778

New container image: sha256:77078e5579d70f97b177ffb5265d08163da65e0e6743376a164c7348c9aa475a
New container tag: 057e56cf5ed9e5dafad7526846b8f476c316d689ebccf1b5504dfc5bff885a30

@nmattia nmattia marked this pull request as ready for review January 16, 2026 17:05
@nmattia nmattia requested a review from a team as a code owner January 16, 2026 17:05
@nmattia nmattia requested a review from a team January 16, 2026 17:05
@nmattia nmattia enabled auto-merge January 16, 2026 17:12
@basvandijk
Copy link
Collaborator

Darn, @cgundy and I discussed this concern.

@nmattia nmattia added this pull request to the merge queue Jan 16, 2026
Merged via the queue into master with commit f3b5bf8 Jan 16, 2026
43 of 44 checks passed
@nmattia nmattia deleted the nm-revert-no-tag branch January 16, 2026 17:36
basvandijk pushed a commit that referenced this pull request Jan 19, 2026
…8413)

Reverts #8404

This reverts the revert, but updates the script logic to now be:
1. If you are in a container, but not the DFINITY container, error out
2. If you are not in a container, drop into the DFINITY container
3. if you are inside the DFINITY container, continue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants