Skip to content

feat(nns): Update self describing proposal descriptions#8532

Merged
jasonz-dfinity merged 6 commits intomasterfrom
jason/misc-proposal-descriptions
Feb 4, 2026
Merged

feat(nns): Update self describing proposal descriptions#8532
jasonz-dfinity merged 6 commits intomasterfrom
jason/misc-proposal-descriptions

Conversation

@jasonz-dfinity
Copy link
Copy Markdown
Contributor

@jasonz-dfinity jasonz-dfinity commented Jan 26, 2026

Update the proposal descriptions based on several rules:

  • Match NNS Dapp
  • Use imperative form - they describe actions, e.g. "A proposal to change ..." => "Change", "Updates ..." => "Update ..."
  • Did not use the ManageNetworkEconomics text from the NNS Dapp, but kept the rewritten one to avoid listing every parameter - they easily get out-dated.

@jasonz-dfinity jasonz-dfinity requested a review from a team as a code owner January 26, 2026 23:04
@github-actions github-actions Bot added the feat label Jan 26, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@jasonz-dfinity jasonz-dfinity force-pushed the jason/misc-proposal-descriptions branch 2 times, most recently from 54c7023 to b38d6ee Compare January 29, 2026 22:19
Comment thread rs/nns/governance/src/proposals/add_or_remove_node_provider.rs
Comment thread rs/nns/governance/src/proposals/manage_neuron.rs
Comment thread rs/nns/governance/src/proposals/self_describing.rs Outdated
@jasonz-dfinity jasonz-dfinity force-pushed the jason/misc-proposal-descriptions branch from b38d6ee to 3a87f47 Compare January 29, 2026 22:50
Copy link
Copy Markdown
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Looks like this just changes some copy. I haven't looked at the new content. I will leave it to Dylan to approve that. This is just a rubber stamp.

Comment thread rs/nns/governance/src/proposals/execute_nns_function.rs Outdated
Comment thread rs/nns/governance/src/proposals/self_describing.rs Outdated
Comment thread rs/nns/governance/src/proposals/execute_nns_function.rs Outdated
Comment thread rs/nns/governance/src/proposals/self_describing.rs Outdated
@jasonz-dfinity jasonz-dfinity added this pull request to the merge queue Feb 4, 2026
Merged via the queue into master with commit 03f5e02 Feb 4, 2026
94 of 97 checks passed
@jasonz-dfinity jasonz-dfinity deleted the jason/misc-proposal-descriptions branch February 4, 2026 19:52
kpop-dfinity pushed a commit that referenced this pull request Feb 5, 2026
Update the proposal descriptions based on several rules:

- Match [NNS
Dapp](https://github.com/dfinity/nns-dapp/blob/main/frontend/src/lib/i18n/en.governance.json)
- Use imperative form - they describe actions, e.g. "A proposal to
change ..." => "Change", "Updates ..." => "Update ..."
- Did not use the ManageNetworkEconomics text from the NNS Dapp, but
kept the rewritten one to avoid listing every parameter - they easily
get out-dated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants