feat(nns): Update self describing proposal descriptions#8532
feat(nns): Update self describing proposal descriptions#8532jasonz-dfinity merged 6 commits intomasterfrom
Conversation
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
54c7023 to
b38d6ee
Compare
b38d6ee to
3a87f47
Compare
daniel-wong-dfinity-org
left a comment
There was a problem hiding this comment.
Yup. Looks like this just changes some copy. I haven't looked at the new content. I will leave it to Dylan to approve that. This is just a rubber stamp.
N/A behind feature flag
Update the proposal descriptions based on several rules: - Match [NNS Dapp](https://github.com/dfinity/nns-dapp/blob/main/frontend/src/lib/i18n/en.governance.json) - Use imperative form - they describe actions, e.g. "A proposal to change ..." => "Change", "Updates ..." => "Update ..." - Did not use the ManageNetworkEconomics text from the NNS Dapp, but kept the rewritten one to avoid listing every parameter - they easily get out-dated.
Update the proposal descriptions based on several rules: