chore: use runtime_deps in //rs/tests/message_routing:queues_compatibility_test #8552
+47
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alin-at-dfinity
approved these changes
Jan 27, 2026
Contributor
alin-at-dfinity
left a comment
alin-at-dfinity
left a comment
There was a problem hiding this comment.
LGTM, thank you.
cgundy
approved these changes
Jan 28, 2026
basvandijk
deleted the
basvandijk/use-runtime_deps-in-queues_compatibility_test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #8449 it's required to specify runtime dependencies of system-tests using the
runtime_depsparameter. This already prepares the//rs/tests/message_routing:queues_compatibility_testfor this requirement.To make this work the
rust_test_with_binarybazel macro had to be rewritten to not symlink to the test binary but to copy it instead. Otherwise the system-test would use theno_opexecutable as its dependency.