Skip to content

Conversation

@pierugo-dfinity
Copy link
Contributor

@pierugo-dfinity pierugo-dfinity commented Jan 29, 2026

Similarly to #8547, this PR spawns the execution of the bash script itself as a blocking task since it also uses blocking I/O.

Unfortunately, I could not simply write

tokio::task::spawn_blocking(move || self.block_on_bash_script_from_session(&session, &script))
    .await
    .expect("Executing bash script task panicked")

because I also had to clone self, which is not Clone. Removing the self parameter from block_on_bash_script_from_session (which is not used) would not be practical either as we would have to adapt every call site.

@github-actions github-actions bot added the fix label Jan 29, 2026
@pierugo-dfinity pierugo-dfinity marked this pull request as ready for review January 29, 2026 15:40
@pierugo-dfinity pierugo-dfinity requested a review from a team as a code owner January 29, 2026 15:40
@github-actions github-actions bot added the @idx label Jan 29, 2026
@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Jan 29, 2026
Merged via the queue into master with commit 181e1d7 Jan 29, 2026
44 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the pierugo/nr_large/spawn_blocking_exec_bash_script branch January 29, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants