Skip to content

Conversation

@cgundy
Copy link
Contributor

@cgundy cgundy commented Feb 3, 2026

This changes the logic of the container-run.sh script back to what it was before by removing --container-cmd and detecting the container command based on environment. This removes some complexity but can be changed in the future if necessary.

@github-actions github-actions bot added the fix label Feb 3, 2026
@cgundy cgundy marked this pull request as ready for review February 3, 2026 09:31
@cgundy cgundy requested a review from a team as a code owner February 3, 2026 09:31
@github-actions github-actions bot added the @idx label Feb 3, 2026
Copy link
Collaborator

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: do cases exists where users actually specify --container-cmd?

In other words: is there a reason we can't simply remove --container-cmd?

@cgundy
Copy link
Contributor Author

cgundy commented Feb 3, 2026

Out of curiosity: do cases exists where users actually specify --container-cmd?

In other words: is there a reason we can't simply remove --container-cmd?

Yeah that's a fair point, since users can also just pass in arguments without specifying --container-cmd. My original intention was to align the inputs with build-image.sh which does accept --container-cmd (though it doesn't accept an additional argument). So I agree with you, it would make more sense to remove it completely. Let me take another look at this.

@cgundy cgundy changed the title fix(IDX): only allow podman commands refactor(IDX): remove --container-cmd Feb 3, 2026
@github-actions github-actions bot added refactor and removed fix labels Feb 3, 2026
@cgundy cgundy requested a review from basvandijk February 3, 2026 10:13
@cgundy cgundy added this pull request to the merge queue Feb 3, 2026
Merged via the queue into master with commit ba8f0b6 Feb 3, 2026
47 checks passed
@cgundy cgundy deleted the dont-allow-non-podman-runs branch February 3, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants