feat(nns): Change the minimum maturity disbursement from 1/0.95 to 1#8667
feat(nns): Change the minimum maturity disbursement from 1/0.95 to 1#8667jasonz-dfinity merged 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
- Added changelog
- Not breaking
- No effect for storage
- No need for security review
…8667) # Why When maturity disbursement feature was added, it used the same minimum for the spawning neurons. For spawning, the minimum requirement has 2 purposes: (1) avoid spawning too many neurons given the same amount of maturity, i.e. avoid DoS (2) the resulting neuron should always have >= 1 ICP stake (minimum stake) with worst maturity modulation (-5%). For maturity disbursement, (2) isn't needed anymore, and the 1/0.95 value is more confusing than 1, without a good reason. # What Check the maturity disbursement >= 1 ICP, directly, without applying worst maturity modulation. Note that since we are lowering the minimum requirement, all maturity disbursement requests that previously succeed will still succeed, while some requests (`[1, 1 / 0.95)`) that previously fail will now succeed. This should not cause confusing behavior in the frontends, and thus frontend changes can be released independently from this.
Why
When maturity disbursement feature was added, it used the same minimum for the spawning neurons. For spawning, the minimum requirement has 2 purposes: (1) avoid spawning too many neurons given the same amount of maturity, i.e. avoid DoS (2) the resulting neuron should always have >= 1 ICP stake (minimum stake) with worst maturity modulation (-5%). For maturity disbursement, (2) isn't needed anymore, and the 1/0.95 value is more confusing than 1, without a good reason.
What
Check the maturity disbursement >= 1 ICP, directly, without applying worst maturity modulation.
Note that since we are lowering the minimum requirement, all maturity disbursement requests that previously succeed will still succeed, while some requests (
[1, 1 / 0.95)) that previously fail will now succeed. This should not cause confusing behavior in the frontends, and thus frontend changes can be released independently from this.