Skip to content

perf: Speed up parameterized upgrade tests#8690

Merged
jasonz-dfinity merged 1 commit intodfinity:masterfrom
dsarlis:dimitris/speed-up-parameterized-tests
Feb 5, 2026
Merged

perf: Speed up parameterized upgrade tests#8690
jasonz-dfinity merged 1 commit intodfinity:masterfrom
dsarlis:dimitris/speed-up-parameterized-tests

Conversation

@dsarlis
Copy link
Copy Markdown
Contributor

@dsarlis dsarlis commented Feb 5, 2026

Last follow up PR that replaces local_test_on_nns_subnet with state_machine_test_on_nns_subnet. Results in significant speed up in 3 out of 4 tests (smaller speed up in the last one) that were using the proc macro parameterized_upgrades.

@dsarlis dsarlis requested a review from a team as a code owner February 5, 2026 09:37
@github-actions github-actions Bot added the perf label Feb 5, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@dsarlis
Copy link
Copy Markdown
Contributor Author

dsarlis commented Feb 5, 2026

Before

//rs/nns/gtc:gtc_integration_test_tests/test_test                        PASSED in 5.1s
//rs/nns/integration_tests:integration_tests_src/root                    PASSED in 39.8s
//rs/registry/canister:registry_canister_integration_test_tests/integration_tests PASSED in 63.3s
//rs/registry/canister:registry_canister_integration_test_tests/integration_tests_2 PASSED in 82.5s

After

//rs/nns/gtc:gtc_integration_test_tests/test_test                        PASSED in 1.9s
//rs/nns/integration_tests:integration_tests_src/root                    PASSED in 35.8s
//rs/registry/canister:registry_canister_integration_test_tests/integration_tests PASSED in 24.2s
//rs/registry/canister:registry_canister_integration_test_tests/integration_tests_2 PASSED in 23.7s

@basvandijk basvandijk added the security-review-passed IDX or InfraSec have concluded it's safe to run CI on the external PR. label Feb 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

@jasonz-dfinity jasonz-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dsarlis

@jasonz-dfinity jasonz-dfinity added this pull request to the merge queue Feb 5, 2026
Merged via the queue into dfinity:master with commit 6178feb Feb 5, 2026
13 checks passed
@dsarlis dsarlis deleted the dimitris/speed-up-parameterized-tests branch February 9, 2026 10:13
kpop-dfinity pushed a commit that referenced this pull request Feb 20, 2026
Last follow up PR that replaces `local_test_on_nns_subnet` with
`state_machine_test_on_nns_subnet`. Results in significant speed up in 3
out of 4 tests (smaller speed up in the last one) that were using the
proc macro `parameterized_upgrades`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor perf security-review-passed IDX or InfraSec have concluded it's safe to run CI on the external PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants