fix(IDX): update publish-crates workflow#8693
Merged
Conversation
cgundy
had a problem deploying
to
publish-crates
GitHub Actions
Failure
cgundy
had a problem deploying
to
publish-crates
GitHub Actions
Failure
cgundy
had a problem deploying
to
publish-crates
GitHub Actions
Failure
cgundy
changed the title
cgundy
changed the title
jwndlng
approved these changes
Feb 5, 2026
Member
jwndlng
left a comment
jwndlng
left a comment
There was a problem hiding this comment.
LGTM! As a minor nit: we could be more explicit by checking == 'false' in the second if.
basvandijk
approved these changes
Feb 5, 2026
kpop-dfinity
pushed a commit
that referenced
this pull request
Feb 20, 2026
This adds correct workflow permissions and introduces a dry-run mode. Successful run here: https://github.com/dfinity/ic/actions/runs/21712164393/job/62618331297 Crate publishing based on this example: https://github.com/dfinity/ic-bn-lib/blob/main/.github/workflows/publish-ic-bn-lib.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds correct workflow permissions and introduces a dry-run mode.
Successful run here: https://github.com/dfinity/ic/actions/runs/21712164393/job/62618331297
Crate publishing based on this example: https://github.com/dfinity/ic-bn-lib/blob/main/.github/workflows/publish-ic-bn-lib.yml