chore: Add a mockall implementation of the Crypto trait#9120
Merged
chore: Add a mockall implementation of the Crypto trait#9120
mockall implementation of the Crypto trait#9120Conversation
eichhorl
changed the title
mockall implementation for the Crypto trait
eichhorl
changed the title
mockall implementation for the Crypto traitmockall implementation of the Crypto trait
basvandijk
approved these changes
Mar 3, 2026
fspreiss
approved these changes
Mar 3, 2026
fspreiss
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to be able to simulate certain crypto failures in some unit tests for NiDKG improvements. This is difficult to do because (until now) there was no complete crypto mock.
A similar IDKG test used a custom implementation of the
Cryptotrait that would pass through to a real crypto implementation, except forsign_basicwhere it returns an error. This would work as well, however it isn't very scalable or customizable.Claude Opus 4.6 instead came up with this PR, which uses
mockallto create aMockCryptostruct. Supposedly this works for all traits except the ones containing lifetime parameters (tECDSA, tSchnorr, vetkd protocol traits). Those traits are instead stubbed withunimplemented. If needed they may be implemented in a custom way, similar to the removedCryptoWrapperFailingBasicSigning.