test(ICP_Rosetta): DEFI-2690: Deflake //rs/rosetta-api/icp:icp_rosetta_system_tests#9226
Merged
mbjorkqvist merged 15 commits intomasterfrom Mar 23, 2026
Merged
Conversation
mbjorkqvist
changed the title
mbjorkqvist
commented
Mar 9, 2026
rs/rosetta-api/icp/tests/system_tests/test_cases/block_synchronization.rs
Show resolved
Hide resolved
rs/rosetta-api/icp/tests/system_tests/test_cases/block_synchronization.rs
Outdated
Show resolved
Hide resolved
# Conflicts: # rs/ledger_suite/icrc1/test_utils/src/lib.rs
…com:dfinity/ic into mathias/DEFI-2690-deflake-icp-rosetta-tests
rs/rosetta-api/icp/tests/system_tests/test_cases/block_synchronization.rs
Outdated
Show resolved
Hide resolved
maciejdfinity
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to deflake
//rs/rosetta-api/icp:icp_rosetta_system_testsas a follow-up to the now-closed PR 9210 by doing the following:insufficient fundsif an earlier transaction failed to make funds in a specific account available. This PR proposes to add some checks and retries for the ledger client responses in an attempt to address the observed flakiness.ArgWithCallerimplementation of theDebugtrait to also log the arguments to enable debugging in case flakiness still occurs.test_load_from_storagehits the internal timeout, the test panics and we get logs to analyze - currently, if the test times out, it is killed, and we get no logs.