feat(exec): List and read canister snapshots according to new visibility settings#9227
Merged
gregorydemay merged 29 commits intomasterfrom Mar 16, 2026
Merged
Conversation
… without PR is already 2_097_610.
gregorydemay
changed the title
This was referenced Mar 6, 2026
gregorydemay
commented
Mar 6, 2026
mraszyk
reviewed
Mar 6, 2026
mraszyk
reviewed
Mar 6, 2026
mraszyk
reviewed
Mar 6, 2026
mraszyk
reviewed
Mar 6, 2026
mraszyk
reviewed
Mar 6, 2026
mraszyk
reviewed
Mar 6, 2026
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
Extract logic to authorize access to some canister data (e.g., logs, snapshots) based on some visibility settings. Sequence of PRs to implement canister snapshot visibility settings as specified in dfinity/portal#6195: 1. #9155 (this) 2. #9158 3. #9227 --------- Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
shilingwang
pushed a commit
that referenced
this pull request
Mar 10, 2026
Extract logic to authorize access to some canister data (e.g., logs, snapshots) based on some visibility settings. Sequence of PRs to implement canister snapshot visibility settings as specified in dfinity/portal#6195: 1. #9155 (this) 2. #9158 3. #9227 --------- Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
Add the types needed for canisters' snapshot visibility settings, to allow principals other than the canister's controllers to be able to list and read canister's snaphots. In short this is like log visibility settings but for canister's snapshots. This PR only adds the needed types and does not change any existing logic. Support for snapshot visibility settings for NNS-owned canisters will be done in #9257. Note that the changes regarding the CMC are needed in this PR because the CMC exposes `ic_management_canister_types_private::CanisterSettingsArgs` via the type `CreateCanister` which is an argument of the `create_canister` endpoint and the test `test_candid_interface_compatibility` ensures that the exposed Canister API is equal to the one declared in `cmc.did`. Sequence of PRs to implement canister snapshot visibility settings as specified in dfinity/portal#6195: 1. #9155 2. #9158 (this) 3. #9227 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
Base automatically changed from
gdemay/DEFI-2667-snapshot-visibility-settings
to
master
March 11, 2026 19:39
# Conflicts: # rs/cycles_account_manager/src/lib.rs # rs/nns/cmc/cmc.did # rs/types/management_canister_types/src/lib.rs
…ta` and `read_canister_snapshot_data`
mraszyk
approved these changes
Mar 13, 2026
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
# Conflicts: # rs/execution_environment/src/canister_manager.rs # rs/execution_environment/src/execution_environment.rs
…lity-logic' into gdemay/DEFI-2667-snapshot-visibility-logic # Conflicts: # rs/execution_environment/src/canister_manager.rs # rs/execution_environment/src/execution_environment.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow access to the endpoints
read_canister_snapshot_metadataread_canister_snapshot_datalist_canister_snapshotsaccording the canister snapshot visibility settings.
Sequence of PRs to implement canister snapshot visibility settings as specified in dfinity/portal#6195: