test: migrate create_subnet test to PocketIC#9279
test: migrate create_subnet test to PocketIC#9279jasonz-dfinity wants to merge 3 commits intomasterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
Migrate test_accepted_proposal_mutates_the_registry_some_subnets_present from the legacy local_test_on_nns_subnet runtime to PocketIC, removing the dependency on Runtime::Local and fake registry clients. Add PocketIC helper functions for reading registry values (subnet list, subnet record, CUP contents) directly from the registry canister.
…egistry_value Replace 4 type-specific helper functions with a single generic decode_registry_value<T> that uses the shared get_value from ic_nervous_system_integration_tests. Add .expect() breadcrumb to create_subnet call. Remove stale section comment.
jasonz-dfinity
force-pushed
the
jason/migrate-create-subnet-test-to-state-machine
branch
from
d5988d3 to
bb6bd1b
Compare
1 participant
Why
The test depends on local_test_on_nns_subnet, Runtime::Local, fake registry clients, and data providers — legacy infrastructure that is being replaced by PocketIC.
What
Migrate the test to PocketIC. The test now calls create_subnet directly on the registry canister with the governance canister as sender, and reads back the subnet list, subnet record, and CUP contents using the shared get_value helper from ic_nervous_system_integration_tests. The local_test_on_nns_subnet import is removed.
PR Chain