chore(ic-backup): don't hold locks during sleeps between rsync retries and ignore *.tmp files while rsyncing#9736
Merged
kpop-dfinity merged 2 commits intomasterfrom Apr 7, 2026
Merged
Conversation
…tmp files while rsyncing
*.tmp files while rsyncing*.tmp files while rsyncing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backuppartition, it first creates a temporary file$dst.tmp, writes to it, and only then renames the file to$dst(seeic/rs/artifact_pool/src/backup.rs
Line 583 in 2450f6d
This means that if we attempt to
rsyncthe content of thebackuppartition, we might run into errors because we might initiate a download while atmpfile (very temporarily) exists. To avoid running intofile has vanishederrors, we propose to ignore all*.tmpfiles.rsync_spoolfunction, including the delays between retries after failures. We propose to hold the lock only for the duration of thersynccommand, and drop the lock immediately if thersynccommand fails.This should help with deflaking
//rs/tests/consensus/backup:backup_manager_{downgrade|upgrade}_test