Skip to content

feat(governance): enable Mission 70 voting rewards#9915

Open
jasonz-dfinity wants to merge 1 commit intomasterfrom
jason/enable-mission-70
Open

feat(governance): enable Mission 70 voting rewards#9915
jasonz-dfinity wants to merge 1 commit intomasterfrom
jason/enable-mission-70

Conversation

@jasonz-dfinity
Copy link
Copy Markdown
Contributor

rs/nns/governance/src/lib.rs: replace Cell::new(cfg!(feature = "test")) with Cell::new(true).

Effects that turn on:

Flip ENABLE_MISSION_70_VOTING_REWARDS from the test-only default
to true so production activates the Mission 70 changes: max dissolve
delay capped at 2 years, voting rewards pool scaled by 0.6329,
quadratic dissolve delay bonus, reduced minimum dissolve delay to
vote, and the 8 year gang 10% voting power bonus.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jasonz-dfinity jasonz-dfinity requested a review from Copilot April 16, 2026 23:32
@github-actions github-actions bot added the feat label Apr 16, 2026
@jasonz-dfinity jasonz-dfinity marked this pull request as ready for review April 16, 2026 23:32
@jasonz-dfinity jasonz-dfinity requested a review from a team as a code owner April 16, 2026 23:32
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables the Mission 70 voting rewards behavior in NNS governance by switching the runtime flag default to “on”, and updates the unreleased changelog to reflect the activation.

Changes:

  • Enable ENABLE_MISSION_70_VOTING_REWARDS by default in rs/nns/governance/src/lib.rs.
  • Add a release-note entry describing the Mission 70 activation in unreleased_changelog.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
rs/nns/governance/unreleased_changelog.md Adds an “Enabled Mission 70 voting rewards” entry describing activated behaviors.
rs/nns/governance/src/lib.rs Flips the Mission 70 voting rewards feature flag default to true (production-enabled).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rs/nns/governance/src/lib.rs
Comment thread rs/nns/governance/unreleased_changelog.md
@bjoernek
Copy link
Copy Markdown
Contributor

I think this PR superseded by
#9923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants