Skip to content

chore: refactor of command invocation handling#143

Merged
rikonor merged 9 commits intomainfrom
or-args
Oct 15, 2025
Merged

chore: refactor of command invocation handling#143
rikonor merged 9 commits intomainfrom
or-args

Conversation

@rikonor
Copy link
Copy Markdown
Contributor

@rikonor rikonor commented Oct 15, 2025

This PR makes several standardizing changes:

  1. Removes the various dispatch functions in favor of a centralized setup in main.
  2. Removes various Command structs that were actually unused.
  3. Standardizes on Subcommand enums being called Command.
  4. Standardizes on exec functions taking reference to args, instead of a cmd, and renames all Cmd structs to <Command>Args.

@rikonor rikonor requested a review from raymondk October 15, 2025 17:19
@rikonor rikonor self-assigned this Oct 15, 2025
@rikonor rikonor requested a review from a team as a code owner October 15, 2025 17:19
Comment thread docs/cli-reference.md Outdated
Comment thread crates/icp-cli/src/commands/canister/mod.rs Outdated
Copy link
Copy Markdown
Contributor

@raymondk raymondk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine other than the ordering of the canister commands. Maybe sorting the enum fixes it.

@rikonor rikonor merged commit 332e3b3 into main Oct 15, 2025
37 checks passed
@rikonor rikonor deleted the or-args branch October 15, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants