feat: Implement snapshot uploading/downloading#330
Merged
adamspofford-dfinity merged 7 commits intomainfrom Feb 3, 2026
Merged
feat: Implement snapshot uploading/downloading#330adamspofford-dfinity merged 7 commits intomainfrom
adamspofford-dfinity merged 7 commits intomainfrom
Conversation
lwshang
reviewed
Feb 3, 2026
| canister_id: Principal, | ||
| snapshot_id: &[u8], | ||
| chunk_hash: &[u8], | ||
| paths: LWrite<&SnapshotPaths>, |
Contributor
There was a problem hiding this comment.
I initially thought paths could use LRead instead. However, since this operation runs within a with_write closure, and the lock system doesn't support downgrading—i.e., treating a write lock as sufficient when only a read lock is needed—we need to keep it as is.
lwshang
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.