feat: Separate network.url into api-url and gateway-url#362
Merged
Conversation
raymondk
reviewed
Feb 13, 2026
raymondk
reviewed
Feb 13, 2026
crates/icp/src/manifest/network.rs
Outdated
Comment on lines
103
to
107
| /// The URL of the gateway endpoint. Should support prefixing canister IDs as subdomains. | ||
| gateway_url: Option<String>, | ||
| /// The URL of the API endpoint. Should support the standard API routes (e.g. /api/v3). | ||
| /// If no gateway endpoint is provided, canister URLs will not be printed in deploy operations. | ||
| api_url: String, |
Contributor
There was a problem hiding this comment.
Suggested change
| /// The URL of the gateway endpoint. Should support prefixing canister IDs as subdomains. | |
| gateway_url: Option<String>, | |
| /// The URL of the API endpoint. Should support the standard API routes (e.g. /api/v3). | |
| /// If no gateway endpoint is provided, canister URLs will not be printed in deploy operations. | |
| api_url: String, | |
| /// The URL of the HTTP gateway. `icp-cli` assumes that it supports prefixing canister IDs as subdomains. | |
| /// If no http gateway is provided, canister URLs will not be printed in deploy operations. | |
| http_gateway_url: Option<String>, | |
| /// The URL of api gateway to use. Should support the standard API routes (e.g. /api/v3). | |
| api_gateway_url: String, |
In our documentation we refer to those as "http gateway" and "api gateway", see: https://docs.internetcomputer.org/references/http-gateway-protocol-spec#api-gateway-resolution
raymondk
reviewed
Feb 13, 2026
crates/icp/src/manifest/network.rs
Outdated
Comment on lines
110
to
112
| /// The URL this network can be reached at. | ||
| /// Assumed to be both gateway (canister-id.domain.com) and API (domain.com/api/v3). | ||
| url: String, |
Contributor
There was a problem hiding this comment.
Suggested change
| /// The URL this network can be reached at. | |
| /// Assumed to be both gateway (canister-id.domain.com) and API (domain.com/api/v3). | |
| url: String, | |
| /// The URL this network can be reached at. | |
| /// Assumed to be the url of the http gateway (canister-id.domain.com) and the api gateway (domain.com/api/v3). | |
| url: String, |
raymondk
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.