feat: point telemetry endpoint to production URL and finalize table schema#391
Merged
feat: point telemetry endpoint to production URL and finalize table schema#391
Conversation
Replace the persistent machine_id (which enabled cross-session tracking) with the already-existing batch UUID that only groups records within a single transmission. This is a better privacy/utility balance. Also add batch and sequence to the "What is collected" table so it serves as a complete schema reference. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Re-add the persistent machine_id field that was removed in the previous commit. A per-installation UUID is standard practice for CLI telemetry (Next.js, .NET CLI, AWS CDK all do this) and enables cross-batch analysis like version upgrade tracking and unique installation counts. The batch/sequence documentation additions from the previous commit are preserved. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lwshang
changed the title
The Vector ingestion service is now live. Replace the `.invalid` placeholder with the real endpoint and add a comment explaining why tests override it back to a non-resolvable address. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lwshang
changed the title
The `telemetry_failed_send_is_silent` test relied on the default endpoint being unreachable, but now that the production URL is live it returns HTTP 200, causing the batch file to be deleted and the test to fail. Fix by using the `icp_with_telemetry!(ctx, enable_send)` macro variant, which redirects to `https://telemetry.invalid/` so the send always fails silently in tests. Also rename the macro flag `allow_upload` → `enable_send` to better describe what it does: it allows `should_send()` to return true so the send trigger fires, but the `.invalid` endpoint ensures no data reaches production. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adamspofford-dfinity
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TELEMETRY_ENDPOINTto the production Vector service (https://icp-cli.dfinity.network/telemetry), replacing the.invalidplaceholderbatchandsequencefields intelemetry.mdTest plan
icp settings telemetrywith the real endpoint, confirmed the record appeared in ClickHouse.invalidso they never hit production