feat: Auto-update network launcher after updating icp-cli#401
Merged
adamspofford-dfinity merged 4 commits intomainfrom Mar 4, 2026
Merged
feat: Auto-update network launcher after updating icp-cli#401adamspofford-dfinity merged 4 commits intomainfrom
adamspofford-dfinity merged 4 commits intomainfrom
Conversation
lwshang
reviewed
Mar 4, 2026
| /// Like [`get_cached_launcher_version`], but for the "latest" tag also checks | ||
| /// whether the launcher was downloaded by an older CLI version, returning `None` | ||
| /// if so. Pinned versions are never considered stale. | ||
| pub fn get_cached_launcher_version_if_fresh( |
Contributor
There was a problem hiding this comment.
get_cached_launcher_version is now only called from crates/icp-cli/tests/common/context.rs, which has a comment saying it replicates the command's logic. Since the command switched to this function, the test helper should match — which would make the old function dead code and allow its removal.
Contributor
Author
There was a problem hiding this comment.
I think the test should use the new function but I don't think the old function should be deleted, some other piece of code may want it in the future.
lwshang
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.