Skip to content

fix: trigger docs deploy via workflow_call from docs.yml#443

Merged
marc0olo merged 1 commit intomainfrom
fix/docs-deploy-workflow-trigger
Mar 18, 2026
Merged

fix: trigger docs deploy via workflow_call from docs.yml#443
marc0olo merged 1 commit intomainfrom
fix/docs-deploy-workflow-trigger

Conversation

@marc0olo
Copy link
Member

@marc0olo marc0olo commented Mar 18, 2026

Problem

Two issues prevented docs-deploy.yml from triggering after docs.yml pushed to docs-deployment:

  1. GITHUB_TOKEN pushes don't trigger other workflows — by design, to prevent infinite loops
  2. workflow_run doesn't fire for tag-triggered workflows — so versioned doc deploys from v* tags would never deploy to the IC

Fix

Use workflow_calldocs.yml explicitly calls docs-deploy.yml as a job after the publish jobs complete.

The deploy-to-ic job is skipped on PR builds via if: github.event_name != 'pull_request'.

Trigger matrix

Event publish jobs deploy-to-ic
Push to main root-files + main-docs succeed ✅ runs
Push to docs/v* or tag v* versioned-docs succeeds ✅ runs
PR all skipped ✅ skipped
Any publish job fails failure ✅ skipped

@marc0olo marc0olo requested a review from a team as a code owner March 18, 2026 08:13
@marc0olo marc0olo force-pushed the fix/docs-deploy-workflow-trigger branch from 28dc896 to cca22ea Compare March 18, 2026 08:22
@marc0olo marc0olo changed the title fix: trigger docs deploy via workflow_run instead of branch push fix: trigger docs deploy via workflow_call from docs.yml Mar 18, 2026
@marc0olo marc0olo force-pushed the fix/docs-deploy-workflow-trigger branch from cca22ea to 4a3435d Compare March 18, 2026 08:25
@marc0olo marc0olo force-pushed the fix/docs-deploy-workflow-trigger branch from 4a3435d to a445d81 Compare March 18, 2026 08:28
workflow_run does not fire for tag-triggered workflows, and GITHUB_TOKEN
pushes do not trigger other workflows. Use workflow_call instead:
docs.yml explicitly calls docs-deploy.yml after publish jobs complete.

The deploy job only runs when at least one publish job succeeded,
so PR builds (where all publish jobs are skipped) do not trigger a deploy.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@marc0olo marc0olo force-pushed the fix/docs-deploy-workflow-trigger branch from a445d81 to 48a9ecb Compare March 18, 2026 08:30
@marc0olo marc0olo enabled auto-merge (squash) March 18, 2026 08:37
@marc0olo marc0olo merged commit 6fffd10 into main Mar 18, 2026
94 checks passed
@marc0olo marc0olo deleted the fix/docs-deploy-workflow-trigger branch March 18, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants