fix: flush buffered stdout once at end of exec to show canister call output#529
Merged
fix: flush buffered stdout once at end of exec to show canister call output#529
Conversation
…output Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
raymondk
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icp canister call --jsonwas producing blank output becauseTerm::buffered_stdout()was never flushed —serde_json::to_writertakes a reference and the buffer held the bytes unsent.term.flush()calls (one per output branch) into a single flush at the end ofexec, after all writes and after propagating any closure error.Test plan
canister_call_json_outputdeploys a canister, callsgreetwith--json, and asserts stdout is non-empty valid JSON with the expectedresponse_bytesandresponse_candidfields — directly covering the regression.canister_call_output_modesand other call tests continue to pass.🤖 Generated with Claude Code