ci: add network-launcher bump and promote workflows#561
Merged
Conversation
Adds a workflow_dispatch workflow that verifies the specified icp-cli-network-launcher release tag exists, updates crates/icp-cli/test-network-launcher-version, and opens a PR via the PR automation bot. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The file is no longer test-only — it pins which release is used for both tests and promotion-to-latest. Move it from crates/icp-cli/test-network-launcher-version to network-launcher-version at the workspace root and update all readers (build.rs, the download script, the bump workflow, and the test module comment). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Triggers on push to main when network-launcher-version changes, reads the file, and dispatches the promote-release workflow in dfinity/icp-cli-network-launcher with the corresponding v-prefixed tag. Uses the pr-automation-bot-public App token scoped to the launcher repo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds CI automation around the icp-cli-network-launcher version pin: a manually triggered workflow to bump the pin (with release-tag verification and PR creation via the pr-automation-bot-public App), and an on-push workflow that dispatches promote-release.yml in the launcher repo whenever the pin file changes on main. The pin file is also promoted out of the test crate to the workspace root to reflect its broader role.
Changes:
- Move
crates/icp-cli/test-network-launcher-versiontonetwork-launcher-versionat the workspace root and updatebuild.rs, the test fixture download script, and the test module comment to read from the new location. - Add
bump-network-launcher.ymlworkflow (manual dispatch) that verifies the release tag, rewrites the pin file, and opens a PR via an App token. - Add
promote-network-launcher.ymlworkflow that, on push tomainmodifying the pin file, dispatchespromote-release.ymlindfinity/icp-cli-network-launcherwith av-prefixed tag.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| network-launcher-version | New workspace-root pin file (moved from crates/icp-cli/). |
| crates/icp-cli/build.rs | Read the pin from the workspace root via CARGO_MANIFEST_DIR and update the rerun-if-changed path. |
| scripts/download_test_network_launcher.sh | Point VERSION_FILE at the new workspace-root location. |
| crates/icp-cli/tests/common/mod.rs | Comment update referring to the renamed pin file. |
| .github/workflows/bump-network-launcher.yml | New workflow: verify tag, update pin, open PR via App token. |
| .github/workflows/promote-network-launcher.yml | New workflow: on main pin change, dispatch promote in launcher repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
raymondk
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two GitHub Actions workflows for managing the
icp-cli-network-launcherversion pin, and moves the pin file out of the test crate to signal its broader role.bump-network-launcher.yml—workflow_dispatchwith a requiredversioninput. Verifies the release tag exists indfinity/icp-cli-network-launcher, writes the stripped version to the pin file, and opens a PR via thepr-automation-bot-publicApp.promote-network-launcher.yml— fires on push tomainwhen the pin file changes. Reads the version, prependsv, and dispatchespromote-release.ymlindfinity/icp-cli-network-launchervia an App token scoped to that repo.crates/icp-cli/test-network-launcher-version→network-launcher-version(workspace root) and updates all readers (build.rs, the download script, the test module comment, and the bump workflow).Prerequisite
The
pr-automation-bot-publicGitHub App must be installed ondfinity/icp-cli-network-launcherwithactions: writefor the promote dispatch to succeed.Test plan
Pre-merge:
cargo build --bin icpandcargo testpass with the moved file.Post-merge (the new workflows are only runnable once on
main):bump-network-launcherwith a valid release tag and confirm the PR is opened with the expected branch / title / file content.promote-network-launcherfires onmainand successfully dispatchespromote-release.ymlin the launcher repo.🤖 Generated with Claude Code