Skip to content

ci: add network-launcher bump and promote workflows#561

Merged
lwshang merged 4 commits into
mainfrom
lwshang/ci_network_launcher_bump_and_promote
May 19, 2026
Merged

ci: add network-launcher bump and promote workflows#561
lwshang merged 4 commits into
mainfrom
lwshang/ci_network_launcher_bump_and_promote

Conversation

@lwshang
Copy link
Copy Markdown
Contributor

@lwshang lwshang commented May 19, 2026

Summary

Adds two GitHub Actions workflows for managing the icp-cli-network-launcher version pin, and moves the pin file out of the test crate to signal its broader role.

  • bump-network-launcher.ymlworkflow_dispatch with a required version input. Verifies the release tag exists in dfinity/icp-cli-network-launcher, writes the stripped version to the pin file, and opens a PR via the pr-automation-bot-public App.
  • promote-network-launcher.yml — fires on push to main when the pin file changes. Reads the version, prepends v, and dispatches promote-release.yml in dfinity/icp-cli-network-launcher via an App token scoped to that repo.
  • Moves crates/icp-cli/test-network-launcher-versionnetwork-launcher-version (workspace root) and updates all readers (build.rs, the download script, the test module comment, and the bump workflow).

Prerequisite

The pr-automation-bot-public GitHub App must be installed on dfinity/icp-cli-network-launcher with actions: write for the promote dispatch to succeed.

Test plan

Pre-merge:

  • cargo build --bin icp and cargo test pass with the moved file.
  • YAML lints / Actions parser accepts both new workflows.

Post-merge (the new workflows are only runnable once on main):

  • Manually trigger bump-network-launcher with a valid release tag and confirm the PR is opened with the expected branch / title / file content.
  • Trigger it with an invalid tag and confirm the verify step fails fast.
  • Merge a bump PR and confirm promote-network-launcher fires on main and successfully dispatches promote-release.yml in the launcher repo.

🤖 Generated with Claude Code

lwshang and others added 3 commits May 19, 2026 10:36
Adds a workflow_dispatch workflow that verifies the specified
icp-cli-network-launcher release tag exists, updates
crates/icp-cli/test-network-launcher-version, and opens a PR via
the PR automation bot.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The file is no longer test-only — it pins which release is used for
both tests and promotion-to-latest. Move it from
crates/icp-cli/test-network-launcher-version to network-launcher-version
at the workspace root and update all readers (build.rs, the download
script, the bump workflow, and the test module comment).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Triggers on push to main when network-launcher-version changes,
reads the file, and dispatches the promote-release workflow in
dfinity/icp-cli-network-launcher with the corresponding v-prefixed
tag. Uses the pr-automation-bot-public App token scoped to the
launcher repo.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@lwshang lwshang requested a review from Copilot May 19, 2026 14:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds CI automation around the icp-cli-network-launcher version pin: a manually triggered workflow to bump the pin (with release-tag verification and PR creation via the pr-automation-bot-public App), and an on-push workflow that dispatches promote-release.yml in the launcher repo whenever the pin file changes on main. The pin file is also promoted out of the test crate to the workspace root to reflect its broader role.

Changes:

  • Move crates/icp-cli/test-network-launcher-version to network-launcher-version at the workspace root and update build.rs, the test fixture download script, and the test module comment to read from the new location.
  • Add bump-network-launcher.yml workflow (manual dispatch) that verifies the release tag, rewrites the pin file, and opens a PR via an App token.
  • Add promote-network-launcher.yml workflow that, on push to main modifying the pin file, dispatches promote-release.yml in dfinity/icp-cli-network-launcher with a v-prefixed tag.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
network-launcher-version New workspace-root pin file (moved from crates/icp-cli/).
crates/icp-cli/build.rs Read the pin from the workspace root via CARGO_MANIFEST_DIR and update the rerun-if-changed path.
scripts/download_test_network_launcher.sh Point VERSION_FILE at the new workspace-root location.
crates/icp-cli/tests/common/mod.rs Comment update referring to the renamed pin file.
.github/workflows/bump-network-launcher.yml New workflow: verify tag, update pin, open PR via App token.
.github/workflows/promote-network-launcher.yml New workflow: on main pin change, dispatch promote in launcher repo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/bump-network-launcher.yml Outdated
Comment thread .github/workflows/bump-network-launcher.yml
Comment thread .github/workflows/bump-network-launcher.yml
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@lwshang lwshang marked this pull request as ready for review May 19, 2026 15:08
@lwshang lwshang requested a review from a team as a code owner May 19, 2026 15:08
@lwshang lwshang merged commit b652c58 into main May 19, 2026
151 of 153 checks passed
@lwshang lwshang deleted the lwshang/ci_network_launcher_bump_and_promote branch May 19, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants