test: drop gratuitous --subnet args; add focused subnet-routing tests#580
Merged
Conversation
The network-launcher 14.0.0 bump makes the `fiduciary` and
`test-threshold-keys` subnets always-on, which shifts the deterministically
derived subnet ids. The hard-coded `common::SUBNET_ID` no longer existed,
breaking ~40 integration tests with `subnet_not_found`.
Most of those tests passed `--subnet` only as cargo-culted boilerplate —
they just need *a* deployed canister, not a specific subnet. `deploy`
auto-selects an application subnet from CMC, so the arg added nothing while
coupling the tests to the launcher topology. Drop `--subnet` (and the
`SUBNET_ID` constant) from all subnet-agnostic tests; they no longer touch
the topology and are immune to future launcher changes.
Keep explicit subnet selection only where it is the point of the test:
- the two CloudEngine tests, now consolidated onto the new
`TestContext::{cloud_engine_subnet_id, subnet_id_by_kind}` helpers that
discover ids from the running network's /_/topology endpoint;
- two new focused tests, `deploy_routes_canister_to_requested_subnet` and
`canister_create_on_requested_subnet`, that assert `--subnet <id>` routes
the canister to the requested subnet (using `application_subnet_id`).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
raymondk
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the network-launcher to
14.0.0-2026-05-29-04-44and fixes the integration-test fallout.fiduciaryandtest-threshold-keyssubnets always-on, which shifts the deterministically-derived subnet ids. The hard-codedSUBNET_IDno longer existed, so ~40 tests failed withsubnet_not_found.--subnetas cargo-culted boilerplate — they just need a canister, not a specific subnet, so they were needlessly coupled to the launcher topology.--subnet(and theSUBNET_IDconstant) from all subnet-agnostic tests, leaving canister creation to auto-select an application subnet.--subnet <id>actually routes the canister to the requested subnet.Supersedes the bot's plain version-bump PR (#579), which left the tests red.
Test plan
With the v14 launcher fixture:
cargo fmtandcargo clippy --tests -p icp-cliclean🤖 Generated with Claude Code