Rewrite https-outcalls Rust for ic-cdk 0.18 API#10
Merged
Conversation
- HttpRequestArgs (not CanisterHttpRequestArgument)
- HttpRequestResult (not HttpResponse)
- TransformFunc::new() (not TransformFunc(candid::Func{}))
- http_request(&request) with auto-cycles (not http_request(request, cycles))
- canister_self() imported from ic_cdk::api
- Blob.empty() → "" : Blob in Motoko
- icrc-ledger: --id-only → icp canister id
JoshDFN
requested review from
derlerd-dfinity and
gregorydemay
as code owners
marc0olo
added a commit
that referenced
this pull request
Mar 25, 2026
Closes #106 - Fix broken `type: custom` recipe with `build.steps` + `type: pre-built` - Fix `init_arg_file` with `init_args: { path, format }` syntax - Add pitfall: minting account cannot call icrc2_approve (#9) - Add pitfall: burn/mint transfers require zero fee (#10) - Rewrite pitfall #1: per-ledger fees, icrc1_fee lookup, BadFee handling - Update init args to use separate minting/funded principals - Show multiple entries in initial_balances - Add icrc1_metadata and icrc1_supported_standards to actor interface - Bump core prerequisite to 2.3.1 - Remove low-value Verify It Works and CLI verification sections - Rename section to Common Pitfalls - Add evaluations with 4 output evals and 16 trigger evals
marc0olo
added a commit
that referenced
this pull request
Mar 25, 2026
) Closes #106 - Fix broken `type: custom` recipe with `build.steps` + `type: pre-built` - Fix `init_arg_file` with `init_args: { path, format }` syntax - Add pitfall: minting account cannot call icrc2_approve (#9) - Add pitfall: burn/mint transfers require zero fee (#10) - Rewrite pitfall #1: per-ledger fees, icrc1_fee lookup, BadFee handling - Update init args to use separate minting/funded principals - Show multiple entries in initial_balances - Add icrc1_metadata and icrc1_supported_standards to actor interface - Bump core prerequisite to 2.3.1 - Remove low-value Verify It Works and CLI verification sections - Rename section to Common Pitfalls - Add evaluations with 4 output evals and 16 trigger evals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major rewrite of Rust section to use ic-cdk 0.18 management_canister types