Skip to content

feat(icp-cli): add instructions for running parallel pocket-ics in wo…#200

Merged
raymondk merged 1 commit into
docs/use-skill-creator-for-new-skillsfrom
rk/parallel-pocket-ic
Jun 1, 2026
Merged

feat(icp-cli): add instructions for running parallel pocket-ics in wo…#200
raymondk merged 1 commit into
docs/use-skill-creator-for-new-skillsfrom
rk/parallel-pocket-ic

Conversation

@raymondk
Copy link
Copy Markdown
Collaborator

@raymondk raymondk commented Jun 1, 2026

…rktrees

@raymondk raymondk requested review from a team and JoshDFN as code owners June 1, 2026 00:07
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Skill Validation Report

Validating skill: /home/runner/work/icskills/icskills/skills/icp-cli

Structure

  • Pass: SKILL.md found
  • Pass: all files in references/ are referenced

Frontmatter

  • Pass: name: "icp-cli" (valid)
  • Pass: description: (507 chars)
  • Pass: license: "Apache-2.0"
  • Pass: metadata: (2 entries)

Tokens

  • Warning: SKILL.md body is 5554 tokens (spec recommends < 5000)

Markdown

  • Pass: no unclosed code fences found

Tokens

File Tokens
SKILL.md body 5,554
references/binding-generation.md 1,031
references/dev-server.md 690
references/dfx-migration.md 2,620
Total 9,895

Content Analysis

Metric Value
Word count 2,917
Code block ratio 0.21
Imperative ratio 0.12
Information density 0.16
Instruction specificity 0.84
Sections 18
List items 60
Code blocks 32

References Content Analysis

Metric Value
Word count 2,133
Code block ratio 0.25
Imperative ratio 0.13
Information density 0.19
Instruction specificity 0.80
Sections 18
List items 33
Code blocks 12

Contamination Analysis

Metric Value
Contamination level low
Contamination score 0.12
Primary language category shell
Scope breadth 3
  • Warning: Language mismatch: config, javascript (2 categories differ from primary)

References Contamination Analysis

Metric Value
Contamination level low
Contamination score 0.03
Primary language category javascript
Scope breadth 2
  • Warning: Language mismatch: shell (1 category differ from primary)

Result: 1 warning

Project Checks


✓ Project checks passed for 1 skills (0 warnings)

@marc0olo
Copy link
Copy Markdown
Member

marc0olo commented Jun 1, 2026

@raymondk was it your intention to first merge into the feature branch or would you want to merge this as a follow up with retargeting to main once #198 is merged?

@raymondk raymondk merged commit 768416e into docs/use-skill-creator-for-new-skills Jun 1, 2026
1 check passed
@raymondk raymondk deleted the rk/parallel-pocket-ic branch June 1, 2026 16:38
raymondk added a commit that referenced this pull request Jun 1, 2026
@marc0olo @raymondk
feat: integrate skill-creator, add improve-ic-skill, overhaul contrib…
6e49de7 
…utor workflow (#198)

* docs: recommend skill-creator for new skill drafting

Replace the template-copy workflow with the Anthropic skill-creator
skill as the recommended starting point. Add explicit callouts for the
IC-specific metadata block (title, category) that skill-creator does not
produce, and clarify the two-phase eval workflow: skill-creator's
internal loop for iterative drafting vs. the committed evaluations/
file required for PRs.

Also remove prescriptive body section recommendations from CLAUDE.md —
structure is individual to each skill and better left to skill-creator.

* docs: extend skill-creator guidance to cover skill improvements

* docs: require eval review and testrun before any skill PR

* docs: fix inconsistencies in contributing guide and agent instructions

* docs: clarify IC evals are kept as regression safety net

* feat: install skill-creator and fix remaining doc inconsistencies

Install skill-creator as a project skill via `npx skills add` so it is
auto-discovered by Claude Code without manual loading. Files land at
.agents/skills/skill-creator/ (multi-agent canonical location) with a
symlink at .claude/skills/skill-creator for Claude Code.

Doc fixes:
- Update skill-creator references to reflect it is pre-installed
- Step 3 renamed "Review and finalize" to avoid implying manual authoring
- Step 6 leads with porting evals from skill-creator's evals.json
- "Keep it flat" bullet now correctly allows references/ subdirectory
- "see step 5 above" cross-reference replaced with anchor link
- CLAUDE.md: add three-file instruction for adding a new category
- CLAUDE.md: mark _template/ as legacy in Project Structure

* fix: correct upstream diff direction in CONTRIBUTING.md (introduced by #194)

* chore: remove legacy skill template; use skill-creator to draft new skills

* feat: add improve-ic-skill, patch skill-creator bugs, remove skills-lock

- Add internal improve-ic-skill skill (.agents/skills/improve-ic-skill/)
  for token-efficient improvement of existing skills. Uses our toolchain
  (npm run validate, evaluate-skills.js with targeted flags), knows eval
  location (evaluations/<skill-name>.json), handles upstream-tracked skills,
  and seeds evals when none exist. Distinct from skill-creator which is for
  new skill creation only.

- Fix 4 confirmed bugs in vendored skill-creator (documented in PATCHES.md):
  1. generate_review.py: escape </script> in JSON output to prevent viewer breakage
  2. SKILL.md: add missing run-1/ level in output paths (aggregate_benchmark.py requires it)
  3. SKILL.md: require eval-0-descriptive-name/ format (aggregator globs eval-*)
  4. SKILL.md: clarify --static is wrong for Claude Code; use server mode instead

- Remove skills-lock.json from git and add to .gitignore. Our skill-creator
  copy is a patched fork — npx skills add would overwrite fixes silently.
  Intentional updates must re-apply patches from PATCHES.md.

- Update CLAUDE.md: distinguish improve-ic-skill vs skill-creator, warn
  against npx skills add updates, clarify that PR eval results must come
  from evaluate-skills.js (with-skill vs baseline), not skill-creator internals.

- Add gitignore entries for skill-creator artifacts (skills/*-workspace/,
  **/__pycache__/, skills-lock.json).

* docs: add targeted eval guidance to upstream sync checklist

* feat(improve-ic-skill): require explicit problem statement before starting any work

* docs(skill-creator): add upstream commit SHA and install date to PATCHES.md

* fix(skill-creator): replace PyYAML with stdlib parser in quick_validate.py (Patch 5)

* fix(skill-creator): add explicit field name warning to grader.md (text/passed/evidence)

* fix: address all review findings — improve-ic-skill, CONTRIBUTING.md, CLAUDE.md, PATCHES.md

- CONTRIBUTING.md: route improvements to improve-ic-skill (not skill-creator);
  fix nonexistent skills/<name>/evals/evals.json path reference
- improve-ic-skill: remove redundant eval run from Step 8 (Step 7 covers it);
  add upstream sync guidance for seeding evals from the diff when none exist
- CLAUDE.md: add improve-ic-skill mention in upstream sync workflow; align
  sync checklist eval policy with general improvement policy
- PATCHES.md: reorder patches 4 and 5 into sequential order

* fix: correct diff notation, clarify Cowork in PATCHES.md, improve Step 8 PR link

* fix: resolve all remaining review findings

- CONTRIBUTING.md: rename 'That's it' step to 'No site edits needed'
- CLAUDE.md: remove redundant eval command from Workflow section; point to
  Evaluations section for the full command reference
- CLAUDE.md: fix stale Project Structure (src/data/ → src/lib/, remove
  non-existent SiteLayout, components/*)
- CLAUDE.md: clarify branch naming — <skill-name> is the IC skill name;
  document combined-branch pattern for multi-skill syncs

* fix: final consistency pass — all third-review findings addressed

- CLAUDE.md: clarify 'Body content' row in upstream table (not icskills-owned)
- CLAUDE.md: scope PR eval requirement to new skills only (line 67)
- CLAUDE.md: fix Project Structure paths (already committed, included here)
- improve-ic-skill: add #8-submit-a-pr anchor to CONTRIBUTING.md link
- CONTRIBUTING.md: add improve-ic-skill and branch naming note to sync section
- PATCHES.md: clarify upstream commit date vs vendored date labels

* fix: clarify branch naming placeholder and PATCHES.md commit SHA label

* feat(improve-ic-skill): hold the line — do not proceed without a clear problem statement

* fix(improve-ic-skill): hard stop in Step 0 — no work without specific problem, no exceptions for pushback

* feat(icp-cli): add instructions for running parallel pocket-ics in worktrees (#200)

---------

Co-authored-by: raymondk <raymond.khalife@dfinity.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lwshang lwshang lwshang approved these changes

@JoshDFN JoshDFN Awaiting requested review from JoshDFN

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raymondk @marc0olo @lwshang