chore: keep .nvmrc in sync with .node-version on bot updates#3711
Merged
chore: keep .nvmrc in sync with .node-version on bot updates#3711
Conversation
Update the node update workflow to also write .nvmrc when bumping the node version, and add .nvmrc to the bot-approved files list so the bot PR passes the repo policy check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the scheduled Node version bump workflow so it keeps both developer-local (.nvmrc) and CI/tooling (.node-version) Node version pins aligned, and ensures bot PRs modifying .nvmrc comply with repository policy.
Changes:
- Write the bumped Node version to
.nvmrcalongside.node-versionin the update workflow. - Expand the workflow PR “add-paths” to include
.nvmrc. - Add
.nvmrcto the bot-approved file allowlist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/update-node.yml |
Ensures the node update bot updates and commits both .node-version and .nvmrc. |
.github/repo_policies/BOT_APPROVED_FILES |
Allows bot PRs to include .nvmrc changes under repo policy checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sea-snake
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nvmrcwhen bumping the node version, keeping it in sync with.node-version.nvmrctoBOT_APPROVED_FILESso the bot PR passes the repo policy checkAddresses review feedback on #3707 — the bot was only updating
.node-versionbut not.nvmrc, causing developers using nvm to potentially run a different Node version than CI.Test plan
.nvmrcis included in the bot PR🤖 Generated with Claude Code