fix: use release tag commit hash in proposal titles#3712
Merged
Conversation
The proposal titles used `git rev-parse --short HEAD` which resolves to whatever commit is currently checked out, not the release tag commit. This caused proposals to display the wrong commit hash when the working directory was on a different branch (e.g. main) than the release tag. Changed all 4 occurrences (dry-run + actual, backend + frontend) to use `git rev-parse --short "$TAG_NAME"` instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes proposal-title commit hashes in the upgrade proposal script by using the release tag’s commit hash instead of the current checkout’s HEAD, preventing incorrect hashes when running from branches other than the release tag commit.
Changes:
- Update backend proposal titles (dry-run + actual) to use
git rev-parse --short "$TAG_NAME". - Update frontend proposal titles (dry-run + actual) to use
git rev-parse --short "$TAG_NAME".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sea-snake
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git rev-parse --short HEAD(current checkout) instead of the release tag's commitmain(or any branch other than the release tag), the title showed the wrong commit hashTest plan
git rev-parse --short "$TAG_NAME"resolves to the correct commit for an existing release tag🤖 Generated with Claude Code