fix(fe): Removing identity from device updates state correctly#3717
Merged
fix(fe): Removing identity from device updates state correctly#3717
Conversation
aterga
approved these changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a state/selection inconsistency when removing an identity “from this device” in the new-styling frontend, ensuring the currently selected identity is switched before removal and properly restored on undo (landing + authorize flows).
Changes:
- Update identity-removal flow to switch selection before removing the currently selected identity.
- Update undo behavior to re-select the restored identity when it was previously current.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/frontend/src/routes/(new-styling)/+page.svelte |
Adjusts landing-page identity removal to avoid leaving selected pointing at a removed identity; undo re-selects when appropriate. |
src/frontend/src/routes/(new-styling)/(channel)/authorize/+layout.svelte |
Mirrors the same selection-before-removal + undo reselect behavior in the authorize layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that removing an identity from device updates state correctly.
Changes