fix(be): Use correct domain separator for sender info#3733
Merged
Conversation
sea-snake
approved these changes
Apr 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to update the signature domain separator used for ICRC-3 “sender info” / attribute-signature generation and verification so it matches the latest IC interface spec draft.
Changes:
- Replace the previous ICRC-3 attribute signature domain (
ic-request-auth-info) with the spec-aligned value (ic-sender-info). - Update both canister-side constants and the corresponding canister-test verification helper to use the corrected domain.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/internet_identity/src/attributes.rs |
Introduces a new domain constant intended for ICRC-3 attribute signatures, aligning with the spec link/value. |
src/canister_tests/src/framework.rs |
Updates the domain constant used by verify_icrc3_attributes to the new spec-aligned value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the value of
DELEGATION_SIG_DOMAINused during the creation of the new ICRC-3 attribute signatures. The correction matches what is described in the latest ICP spec draft.