Skip to content

Marvin/e2e debug flaky#394

Closed
mminder wants to merge 29 commits intomainfrom
marvin/e2e-debug-flaky
Closed

Marvin/e2e debug flaky#394
mminder wants to merge 29 commits intomainfrom
marvin/e2e-debug-flaky

Conversation

@mminder
Copy link
Copy Markdown
Contributor

@mminder mminder commented Sep 16, 2021

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mminder mminder force-pushed the marvin/e2e-debug-flaky branch 5 times, most recently from ea77fde to 4d6a4f4 Compare September 17, 2021 12:50
mminder and others added 25 commits September 17, 2021 15:07
add debug log to gather more information about flaky screenshot test
cff0f7a
increase timeout even more
08f37fe
start selenium before running tests to avoid complex start, retry and…
ab29b9b 
… kill logic
wait before pressing login
e6eb06e
fix selenium start command
7cdb7e6
try to debug out login click timing
4c99b84
increase log
eec50fa
Updating frontend formatting
11ab94c
increase connection logging
e235d9a
Updating frontend formatting
216ca47
decrease test timeouts
3f1e55c
increase add device logs
b539440
Updating frontend formatting
c6cf600
reduce wait timeout
a48de54
add more logs during login
b37e78e
add log
7c3f8b6
increase log
4986b81
output browser2 logs to exclude cross effects
7d5a157
try without session delete
8d75d56
increase dfx version
aa84006
increase timeout after login to get max logs
a6b9c3c
increase timeouts
5b4101f
wait even longer
4439ae9
Updating frontend formatting
88ac55b
reset test timeouts
8afe86c
@mminder mminder force-pushed the marvin/e2e-debug-flaky branch from 45ec30a to 167b1d8 Compare September 17, 2021 13:10
@mminder mminder force-pushed the marvin/e2e-debug-flaky branch from 167b1d8 to 32c0fa9 Compare September 17, 2021 13:11
@mminder mminder force-pushed the marvin/e2e-debug-flaky branch from 75636cf to 5176a3c Compare September 17, 2021 13:43
@mminder mminder force-pushed the marvin/e2e-debug-flaky branch from 5176a3c to 79dedaf Compare September 17, 2021 13:48
@mminder mminder closed this Sep 17, 2021
@mminder
Copy link
Copy Markdown
Contributor Author

mminder commented Sep 17, 2021

issue was found

@nmattia nmattia deleted the marvin/e2e-debug-flaky branch August 23, 2022 07:24
@aterga aterga mentioned this pull request Apr 2, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mminder