IC-128: First iteration of serving assets#9
Merged
Conversation
80b10b7 to
bb21a07
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a very first implementation of serving assets from the IdP canister. I'm using two hard-coded assets for now to be able to implement the basic pieces of the interface. It basically initializes a map of assets during
canister_initand then exposes thehttp_requestquery function required for the HTTP gateway to ask for assets.Work left for future PRs:
StreamingStrategyyet in the interface (see here for what's aStreamingStrategy), I need to figure out how to do that in Rust in a way that Candid understands.canister_init, likely as an input argument.Testing
To install the canister locally:
Then you can ask for an asset:
If an asset does not exist: