fix(pic): include request path in PocketIC server error messages (#70)#249
Merged
nikosxenakis merged 3 commits intomainfrom Mar 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves PocketIC client diagnostics by including the HTTP request path in ServerError messages emitted from the HTTP2 client, making it easier to identify which in-flight request failed (e.g., after an instance is deleted).
Changes:
- Append
init.pathtoServerErrormessages thrown on{ message: ... }error responses injsonGet. - Append
init.pathtoServerErrormessages thrown on{ message: ... }error responses injsonPost. - Update the
Http2Clientunit test expectation forjsonGeterror messaging.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/pic/src/http2-client.ts | Adds request path context to ServerError messages for error responses in jsonGet/jsonPost. |
| packages/pic/tests/src/util/http2-client.spec.ts | Updates jsonGet error-response test to match the new error message format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
viviveevee
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a PocketIC instance is deleted while async operations are still in-flight, the resulting "Instance was deleted"
error provides no context about which call was orphaned, making it hard to track
down the offending line.
Closes #70
Summary
ServerErrormessages thrown byjsonGetandjsonPostin the HTTP client, e.g.PocketIC server error: Instance was deleted (/api/v2/instances/0/read/query)