chore(IDX): add github token to CLA check#159
Conversation
|
A general comment: Can we please use pinned actions instead of version/branches? |
Sure, I'll actually add that to a different PR first |
Addressed in #160 |
Are you sure? The example from superbrothers/close-pull-request doesn't mention that a checkout is needed.
The example from actions/github-script? also doesn't mention you need a checkout. |
|
I think the checkout is used so that the context changes to the other repo and the GH commands will automatically target this repo. This can potentially be avoided by explicitly naming the target repo. E.g. could be |
|
So actually, the error we were getting was a permissions error: https://github.com/dfinity/pic-js/actions/runs/15072330334/job/42371540281?pr=134 - is it possible the issue is something else entirely? The CLA github app has write access to pull requests for all repos, so I assumed it was related to the change we made with removing the checkout step. |
|
I can try Jan's suggestion as well |
* chore(IDX): add workflow_call back (#158) * chore(IDX): pin action to commit (#160) * chore(IDX): add github token to CLA check (#159) * chore(IDX): add checkout steps back to the CLA * switch to base * switch to base * update owner and repo * update * add context * update ref * update token * chore(IDX): add new bot to list of approved bots (#161) * Update check_cla_ruleset.yml (#162) Cleaning up quotes * chore(deps): bump requests from 2.32.3 to 2.32.4 (#163) Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.3...v2.32.4) --- updated-dependencies: - dependency-name: requests dependency-version: 2.32.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump urllib3 from 2.2.3 to 2.5.0 (#164) Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.3 to 2.5.0. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.3...2.5.0) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.5.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(IDX): allow testing with droid-uexternal user (#165) Temporarily allow 'droid-uexternal' bot to contribute for testing. * Revert "chore(IDX): allow testing with droid-uexternal user (#165)" (#167) This reverts commit 2262404. * chore: close external PRs that touch blacklisted files (#166) Instead of just commenting on external PRs that touch blacklisted files this commit causes them to be closed as well. We intend to use this in dfinity/ic to automatically close PRs by non-DFINITY contributors that touch files under `.github`. See: dfinity/ic#7307. This also changes the definition of an "external" PR from any PR created by a non-DFINITY member to any PR created from a fork. The latter is easier to determine because we don't need to query the GitHub API. Also note that the set of PRs created from forks includes the set of PRs created by non-DFINITY members since non-DFINITY members can create PRs from source repos since they're not allowed to push there. Finally this commit simplifies the `reusable_workflows/repo_policies/check_external_changes.py` Python code by not fetching the `.github/repo_policies/EXTERNAL_CONTRIB_BLACKLIST` file from within the script but using the `actions/checkout` action instead. Tested here: dfinity/test-compliant-repository-public#72 (comment). --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Marko Kosmerl <marko.kosmerl@dfinity.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bas van Dijk <bas@dfinity.org>
There was a permissions issue with running the CLA, so I'm trying to add the token.