Skip to content

fix(e2e): fabricate cycles before setting high freezing threshold#4526

Merged
lwshang merged 1 commit intomasterfrom
fix-update-settings-cycles
Apr 17, 2026
Merged

fix(e2e): fabricate cycles before setting high freezing threshold#4526
lwshang merged 1 commit intomasterfrom
fix-update-settings-cycles

Conversation

@ggreif
Copy link
Copy Markdown
Contributor

@ggreif ggreif commented Apr 17, 2026

Summary

The set freezing threshold test in update_settings.bash fails with newer replica versions because the canister runs out of cycles when a 100B freezing threshold is set before topping up.

Fix: move fabricate-cycles before the update-settings --freezing-threshold call.

Split from #4514 so the bot-authored replica update PR doesn't need to touch test files.

Test plan

  • test (dfx/update_settings) passes in CI

The new replica requires more cycles to sustain an extreme freezing
threshold (100B). Top up the canister before update-settings so it
doesn't freeze and reject subsequent calls.
@ggreif ggreif requested a review from a team as a code owner April 17, 2026 01:10
@lwshang lwshang merged commit ac32d39 into master Apr 17, 2026
30 checks passed
@lwshang lwshang deleted the fix-update-settings-cycles branch April 17, 2026 01:11
@ggreif ggreif self-assigned this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants