Skip to content

chore: update dependencies in examples#86

Merged
ielashi merged 3 commits into
dfinity:mainfrom
peterpeterparker:chore/ciborium
Jun 2, 2023
Merged

chore: update dependencies in examples#86
ielashi merged 3 commits into
dfinity:mainfrom
peterpeterparker:chore/ciborium

Conversation

@peterpeterparker

@peterpeterparker peterpeterparker commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

Motivation

Few (24) days ago a new version of ciborium was released.
Therefore we can use the official dependency in the quickstart example instead of referencing a particular commit.

In addition, this PR bumps the candid and ic-* dependencies of the examples as provided by @ielashi.

@peterpeterparker peterpeterparker requested review from a team and roman-kashitsyn as code owners June 1, 2023 12:38
@ielashi

ielashi commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

Looks like the examples are not passing. You need to regenerate the Cargo.lock file there.

@peterpeterparker

Copy link
Copy Markdown
Contributor Author

@ielashi you mean in ./examples/src? I get an error

❯ cargo update
    Updating crates.io index
error: failed to select a version for the requirement `ic-cdk = "^0.4"`
candidate versions found which didn't match: 0.8.1, 0.8.0, 0.7.4, ...

While I'm there, should I bump all dependencies of the examples?

@ielashi ielashi changed the title chore: use ciborium crate last release in example chore: update dependencies in examples Jun 2, 2023
@ielashi ielashi merged commit 49d0bf4 into dfinity:main Jun 2, 2023
@peterpeterparker peterpeterparker deleted the chore/ciborium branch June 2, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants