feat: stable min heap data structure#91
Merged
Merged
Conversation
This change introduces the `MinHeap` stable structure analogous to `std::collections::BinaryHeap`. Contrary to `BinaryHeap`, `MinHeap` prioritizes smaller items, which I found much more useful in practice than prioritizing larger items.
ielashi
approved these changes
Jun 22, 2023
ielashi
left a comment
ielashi
left a comment
Contributor
There was a problem hiding this comment.
Nice and simple, thanks!
Contributor
|
Maybe also adding an example to the examples folder would be nice? |
AlexandraZapuc
approved these changes
Jun 23, 2023
Contributor
Author
I've added an example, PTAL. |
ielashi
approved these changes
Jun 28, 2023
ielashi
left a comment
ielashi
left a comment
Contributor
There was a problem hiding this comment.
Example also LGTM. Thanks @roman-kashitsyn!
ielashi
added a commit
that referenced
this pull request
Jul 3, 2023
We've introduced a new min heap data structure in #91, and this version makes it accessible to our users. --------- Co-authored-by: Roman Kashitsyn <roman@dfinity.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces the
MinHeapstable structure analogous tostd::collections::BinaryHeap.Contrary to
BinaryHeap,MinHeapprioritizes smaller items, which I found much more useful in practice than prioritizing larger items.