Skip to content

chore: CRP-2823 modularize parts of the vetKD-related code in examples to simplify them#135

Merged
altkdf merged 2 commits intomainfrom
alex/simplify-basic-examples
Jun 5, 2025
Merged

chore: CRP-2823 modularize parts of the vetKD-related code in examples to simplify them#135
altkdf merged 2 commits intomainfrom
alex/simplify-basic-examples

Conversation

@altkdf
Copy link
Copy Markdown
Contributor

@altkdf altkdf commented Jun 4, 2025

This makes it easier to use them in developer docs.

@altkdf altkdf requested a review from fspreiss June 4, 2025 18:16
@altkdf altkdf marked this pull request as ready for review June 4, 2025 18:16
@altkdf altkdf requested a review from a team June 4, 2025 18:16
@altkdf
Copy link
Copy Markdown
Contributor Author

altkdf commented Jun 4, 2025

Does this make sense to you @fspreiss ?

@altkdf
Copy link
Copy Markdown
Contributor Author

altkdf commented Jun 4, 2025

Note: I didn't yet check that nothing is broken in the examples.

@altkdf altkdf changed the title chore: modularize parts of the vetKD-related code in examples to simplify them chore: CRP-2823 modularize parts of the vetKD-related code in examples to simplify them Jun 5, 2025
Copy link
Copy Markdown
Contributor

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @altkdf!

@altkdf
Copy link
Copy Markdown
Contributor Author

altkdf commented Jun 5, 2025

Checked that the examples still work.

@altkdf altkdf merged commit d8bb5d4 into main Jun 5, 2025
12 checks passed
@altkdf altkdf deleted the alex/simplify-basic-examples branch June 5, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants