chore: Fix building the Rust password_manager example#267
Merged
Conversation
The password_manager example failed to build because the `backend` symlink points
to a canister that uses workspace dependency inheritance ({ workspace = true }),
but the example's own workspace didn't define `[workspace.dependencies]`.
Fixed by adding the required workspace dependencies to both the example's
`Cargo.toml` and the root `Cargo.toml`, and updating the canister to use
workspace inheritance for ic-vetkeys.
Contributor
Author
|
This got broken by #252 but was missed due to the CI workflow paths being quite incomplete (missing |
randombit
changed the title
fspreiss
approved these changes
Jan 13, 2026
Contributor
fspreiss
left a comment
fspreiss
left a comment
There was a problem hiding this comment.
Thanks for fixing this, @randombit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The password_manager example failed to build because the
backendsymlink points to a canister that uses workspace dependency inheritance ({ workspace = true }), but the example's own workspace didn't define[workspace.dependencies].Fixed by adding the required workspace dependencies to both the example's
Cargo.tomland the rootCargo.toml, and updating the canister to use workspace inheritance for ic-vetkeys.