feat: migrate @dfinity/* to @icp-sdk/core and icp-cli#378
Merged
andreacerulli merged 5 commits intochore/remove-examplesfrom Apr 21, 2026
Merged
feat: migrate @dfinity/* to @icp-sdk/core and icp-cli#378andreacerulli merged 5 commits intochore/remove-examplesfrom
andreacerulli merged 5 commits intochore/remove-examplesfrom
Conversation
a7b1a1e to
9ece6d1
Compare
Migrate the frontend library and backend infrastructure from deprecated
@dfinity/* packages and dfx to @icp-sdk/core and icp-cli.
Frontend library (frontend/ic_vetkeys):
- Replace @dfinity/{agent,principal,candid,identity} with @icp-sdk/core
- Regenerate declarations with @icp-sdk/bindgen@0.3.0
- Replace createActor wrappers with direct Actor.createActor calls
- Update test host ports and add canister ID null guards
- Reformat tsconfig, vite.config, eslint config
Backend infrastructure:
- Replace dfx.json with icp.yaml for all backend canisters
- Update Makefiles for icp-cli compatible builds
- Update test key from dfx_test_key to test_key_1
- Update CI workflows for icp-cli
CI:
- Update frontend.yml and backend-motoko.yml for icp-cli
- Update provision scripts
- Add .icp to .gitignore
The test scripts use icp-cli commands but the provision scripts were still installing dfx. Replace dfx installation with npm install -g @icp-sdk/icp-cli.
9ece6d1 to
9738b28
Compare
marc0olo
reviewed
Apr 21, 2026
marc0olo
reviewed
Apr 21, 2026
An error occurred while trying to automatically change base from
chore/remove-examples
to
main
April 21, 2026 09:53
randombit
approved these changes
Apr 21, 2026
Contributor
randombit
left a comment
There was a problem hiding this comment.
I did not look at all at files with comments like
This file was automatically generated by @icp-sdk/bindgen@0.3.0.
Everything else looks good to me.
andreacerulli
added a commit
that referenced
this pull request
Apr 22, 2026
Migrate the frontend library and backend infrastructure from deprecated
@dfinity/* packages and dfx to @icp-sdk/core and icp-cli.
Frontend library (frontend/ic_vetkeys):
- Replace @dfinity/{agent,principal,candid,identity} with @icp-sdk/core
- Regenerate declarations with @icp-sdk/bindgen@0.3.0
- Replace createActor wrappers with direct Actor.createActor calls
- Update test host ports and add canister ID null guards
- Reformat tsconfig, vite.config, eslint config
Backend infrastructure:
- Replace dfx.json with icp.yaml for all backend canisters
- Update Makefiles for icp-cli compatible builds
- Update test key from dfx_test_key to test_key_1
- Update CI workflows for icp-cli
CI:
- Update frontend.yml and backend-motoko.yml for icp-cli
- Update provision scripts
- Add .icp to .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the frontend library and backend infrastructure from deprecated @dfinity/* packages and dfx to @icp-sdk/core and icp-cli.
Frontend library (frontend/ic_vetkeys):
Backend infrastructure:
CI: