Skip to content

feat: migrate @dfinity/* to @icp-sdk/core and icp-cli#378

Merged
andreacerulli merged 5 commits intochore/remove-examplesfrom
chore/migrate-to-icp-sdk
Apr 21, 2026
Merged

feat: migrate @dfinity/* to @icp-sdk/core and icp-cli#378
andreacerulli merged 5 commits intochore/remove-examplesfrom
chore/migrate-to-icp-sdk

Conversation

@andreacerulli
Copy link
Copy Markdown
Contributor

Migrate the frontend library and backend infrastructure from deprecated @dfinity/* packages and dfx to @icp-sdk/core and icp-cli.

Frontend library (frontend/ic_vetkeys):

  • Replace @dfinity/{agent,principal,candid,identity} with @icp-sdk/core
  • Regenerate declarations with @icp-sdk/bindgen@0.3.0
  • Replace createActor wrappers with direct Actor.createActor calls
  • Update test host ports and add canister ID null guards
  • Reformat tsconfig, vite.config, eslint config

Backend infrastructure:

  • Replace dfx.json with icp.yaml for all backend canisters
  • Update Makefiles for icp-cli compatible builds
  • Update test key from dfx_test_key to test_key_1
  • Update CI workflows for icp-cli

CI:

  • Update frontend.yml and backend-motoko.yml for icp-cli
  • Update provision scripts
  • Add .icp to .gitignore

@andreacerulli andreacerulli force-pushed the chore/migrate-to-icp-sdk branch from a7b1a1e to 9ece6d1 Compare April 21, 2026 08:06
@andreacerulli andreacerulli marked this pull request as ready for review April 21, 2026 08:06
@andreacerulli andreacerulli requested a review from a team as a code owner April 21, 2026 08:06
Migrate the frontend library and backend infrastructure from deprecated
@dfinity/* packages and dfx to @icp-sdk/core and icp-cli.

Frontend library (frontend/ic_vetkeys):
- Replace @dfinity/{agent,principal,candid,identity} with @icp-sdk/core
- Regenerate declarations with @icp-sdk/bindgen@0.3.0
- Replace createActor wrappers with direct Actor.createActor calls
- Update test host ports and add canister ID null guards
- Reformat tsconfig, vite.config, eslint config

Backend infrastructure:
- Replace dfx.json with icp.yaml for all backend canisters
- Update Makefiles for icp-cli compatible builds
- Update test key from dfx_test_key to test_key_1
- Update CI workflows for icp-cli

CI:
- Update frontend.yml and backend-motoko.yml for icp-cli
- Update provision scripts
- Add .icp to .gitignore
The test scripts use icp-cli commands but the provision scripts
were still installing dfx. Replace dfx installation with
npm install -g @icp-sdk/icp-cli.
@andreacerulli andreacerulli force-pushed the chore/migrate-to-icp-sdk branch from 9ece6d1 to 9738b28 Compare April 21, 2026 08:10
@andreacerulli andreacerulli requested a review from randombit April 21, 2026 08:24
Comment thread backend/mo/canisters/ic_vetkeys_encrypted_maps_canister/icp.yaml Outdated
Comment thread backend/mo/canisters/ic_vetkeys_manager_canister/icp.yaml Outdated
An error occurred while trying to automatically change base from chore/remove-examples to main April 21, 2026 09:53
Copy link
Copy Markdown
Contributor

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at all at files with comments like

This file was automatically generated by @icp-sdk/bindgen@0.3.0.

Everything else looks good to me.

@andreacerulli andreacerulli merged commit 56b275d into chore/remove-examples Apr 21, 2026
27 of 28 checks passed
andreacerulli added a commit that referenced this pull request Apr 22, 2026
Migrate the frontend library and backend infrastructure from deprecated
@dfinity/* packages and dfx to @icp-sdk/core and icp-cli.

Frontend library (frontend/ic_vetkeys):
- Replace @dfinity/{agent,principal,candid,identity} with @icp-sdk/core
- Regenerate declarations with @icp-sdk/bindgen@0.3.0
- Replace createActor wrappers with direct Actor.createActor calls
- Update test host ports and add canister ID null guards
- Reformat tsconfig, vite.config, eslint config

Backend infrastructure:
- Replace dfx.json with icp.yaml for all backend canisters
- Update Makefiles for icp-cli compatible builds
- Update test key from dfx_test_key to test_key_1
- Update CI workflows for icp-cli

CI:
- Update frontend.yml and backend-motoko.yml for icp-cli
- Update provision scripts
- Add .icp to .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants