feat: CRP-2673 implement password manager with metadata#5

Merged

altkdf merged 21 commits intomainfrom

alex/add-password-manager-with-metadata

Mar 17, 2025

Contributor

altkdf commented Feb 25, 2025

No description provided.

altkdf added 2 commits

February 25, 2025 01:10


          implement password manager with metadata

421ca5e


          remove some console outputs

f9d87ab

altkdf changed the title ~~implement password manager with metadata~~ feat: CRP-2673 implement password manager with metadata


          Merge branch 'main' into alex/add-password-manager-with-metadata

3db18b0

altkdf marked this pull request as ready for review

February 26, 2025 11:40

altkdf requested review from a team, fspreiss and randombit

February 26, 2025 11:40

altkdf added 2 commits

March 10, 2025 10:39


          Merge branch 'main' into alex/add-password-manager-with-metadata

37e20cf


          don't compile cdk stuff for non-wasm

7e1a0f9

altkdf commented

View reviewed changes

examples/password_manager_with_metadata/backend/src/wasm_only.rs Outdated

altkdf commented

View reviewed changes

examples/password_manager_with_metadata/backend/src/wasm_only.rs Outdated

altkdf commented

View reviewed changes

examples/password_manager_with_metadata/backend/src/wasm_only.rs Outdated

altkdf commented

View reviewed changes

examples/password_manager_with_metadata/frontend/README.md Outdated

altkdf commented

View reviewed changes

examples/password_manager_with_metadata/frontend/package.json Outdated

altkdf requested a review from kristoferlund

March 12, 2025 08:40

altkdf added 9 commits

March 12, 2025 09:55


          add type aliases

42cf9fd


          add link to blog post

b5664fd


          improvements to deployment script, readme, and imports

66a8a77


          rm unused line

a192f73


          add eslint

719aa80


          run eslint --fix

fd80736


          fix stuff marked by eslint

b0a276d


          add prettier

5a6d56b


          add svelte prettier and run prettier

ba23b72

kristoferlund requested changes

View reviewed changes

Contributor

kristoferlund left a comment

In general I think the app code is well structured. I like how Svelte works with global reactive state, in many ways a more clean approach than the one React is using.

I have not commented on the layout of the UI at all. Let's talk about that later.

examples/password_manager_with_metadata/frontend/vite.config.js

examples/password_manager_with_metadata/frontend/src/app.css

examples/password_manager_with_metadata/frontend/src/components/Vaults.svelte

examples/password_manager_with_metadata/frontend/src/lib/password_manager.ts Outdated

examples/password_manager_with_metadata/frontend/package.json Outdated

examples/password_manager_with_metadata/backend/src/wasm_only.rs Outdated

examples/password_manager_with_metadata/backend/src/wasm_only.rs Outdated

examples/password_manager_with_metadata/frontend/src/lib/password.ts

examples/password_manager_with_metadata/frontend/src/lib/enums.ts Outdated

examples/password_manager_with_metadata/frontend/src/lib/vault.ts Outdated

altkdf added 4 commits

March 12, 2025 15:06


          fix css errors and II env variable name

7b8e388


          address more feedback, remove some warnings

1bccbff


          fix security policy for wasm and rm some unused imports

f436e94


          rm empty file

67450ba

altkdf added 3 commits

March 14, 2025 14:36


          fix name encoding

780e8f1


          lib.rs

cddfce5


          add workflow

9214f08

fspreiss approved these changes

View reviewed changes

Contributor

fspreiss left a comment

Approving this to unblock the PR. We can always iterate on it.

kristoferlund approved these changes

View reviewed changes

altkdf merged commit efaafd3 into main

5 checks passed

altkdf deleted the alex/add-password-manager-with-metadata branch

March 21, 2025 16:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet