Skip to content

Conversation

@naderman
Copy link
Contributor

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the duplicate in the echo but not on line 330 above where it is done for real. It is unclear to me if I actually need both w/ and w/o tags. If you know for sure we don't need git fetch bare you can comment out the actual line above, too, if you want to. I always thought --tags were optional and if you did get tags it was tags only. Though that might just be git push behavior. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha oops, was copying this from a modified version, sorry.

And yes, it specifically says so in the docs: "-t, --tags: Fetch all tags from the remote [...] in addition to whatever else would otherwise be fetched."

simensen added a commit that referenced this pull request Jan 26, 2016
Fix duplicate fetch, -t option fetches other refs too
@simensen simensen merged commit 5022114 into dflydev:master Jan 26, 2016
@naderman naderman deleted the fix-duplicate-fetch branch January 26, 2016 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants