Add arviz 1.0.0 compatibility and pandas image test tolerance#325
Conversation
…, add tolerance for pandas image test Co-authored-by: dfm <350282+dfm@users.noreply.github.com>
Co-authored-by: dfm <350282+dfm@users.noreply.github.com>
|
@copilot I guess we should bump the minimum required version for Arviz too |
Co-authored-by: dfm <350282+dfm@users.noreply.github.com>
|
@copilot please fix the readthedocs and pre-commit failures |
…deps, restore import fallbacks Co-authored-by: dfm <350282+dfm@users.noreply.github.com>
Fixed in 9e6424d. The pre-commit failure was black formatting on |
|
@copilot it would be better to just bump the python version on readthedocs |
Co-authored-by: dfm <350282+dfm@users.noreply.github.com>
Bumped readthedocs Python from 3.10 to 3.12 in |
|
@copilot read the docs still seems to be failing! |
…ump OS to ubuntu-22.04 Co-authored-by: dfm <350282+dfm@users.noreply.github.com>
The readthedocs failure was caused by the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot looks like we'll need to keep supporting older versions of arviz after all. Let's make this change conditional. |
…ions Co-authored-by: dfm <350282+dfm@users.noreply.github.com>
Reverted |
Two persistent test failures on all PRs off main:
test_arviz(API breakage) andtest_pandas(image comparison drift).arviz 1.0.0 API changes
arviz 1.0.0 restructured into
arviz,arviz_base,arviz_stats,arviz_plotspackages. All changes are conditional to maintain backward compatibility with older arviz versions.src/corner/arviz_corner.py: Added three-level try/except import fallbacks to support very old arviz (arviz.plots.plot_utils), medium arviz <1.0 (arviz.utils,arviz.sel_utils,arviz.labels), and arviz >=1.0 (arviz/arviz_base.labelswith local reimplementations of_var_namesandget_coords).tests/test_corner.py:az.from_dict()call wrapped in try/except TypeError to support both old keyword-arg syntax and new single nested dict syntax for arviz 1.0+.docs/pages/arviz.ipynb: Same try/except pattern for theaz.from_dict()call in the ArviZ documentation notebook, which is executed during the Sphinx docs build (nb_execution_mode = "force").pyproject.toml: Kept atarviz>=0.9to maintain backward compatibility with older arviz versions.readthedocs.yaml: Bumped OS fromubuntu-20.04toubuntu-22.04and Python version from 3.10 to 3.12.pandas image comparison
tol=7totest_pandas@image_comparisondecorator. The RMS of 6.072 is consistent across CI runs due to font rendering differences on GitHub Actions runners.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.